C# Sql 从对象列表逐行更新

Question

public int UpdateAmount(List<MyTable> myBizObjList)
     {
         SqlTransaction sqltxn;
         DbClass db = new DbClass();
         SqlConnection cs;
         cs = db.GetConnection();

         string commandText = @"Update MyTable Set amt = @amt  where empno = @empno and mydate = @mydate";

         int x = myBizObjList.Count;
         int y = 0,rowsaffected;
         cs.Open();

         using (cs)
         {
             sqltxn = cs.BeginTransaction();
             foreach (MyTable myBizObj in myBizObjList)
              { 
                 SqlCommand command = new SqlCommand(commandText, cs, sqltxn);
                 command.Parameters.Add("@empno", SqlDbType.Int);
                 command.Parameters["@empno"].Value = myBizObj.Empno;
                 command.Parameters.Add("@mydate", SqlDbType.Date);
                 command.Parameters["@mydate"].Value = myBizObj.Mydate;
                 command.Parameters.Add("@amt", SqlDbType.Decimal);
                 command.Parameters["@amt"].Value = myBizObj.Amt;
                                 
                 
                 try
                 {
                     rowsAffected = command.ExecuteNonQuery();
                     if (rowsAffected == 1)
                         y++;
                 }
                 catch (Exception ex)
                 {
                     throw (ex);
                    
                 }
             }
             if (y == x)
             {
                 sqltxn.Commit();
                 
             }
             else
             {
                sqltxn.Rollback();
                 y = 0;
             }
             cs.Close();
             return y;
         }
         
     }

Question: I am querying a table and getting say 50K records which I am converting to a List of objects. I am processing the List in my BLL and sending to my DAL. The above is a method in my DAL. Is there a better way? I am also checking if all rows are updated & then Commit or Rollback.

Answer 1

You can convert this to a table-valued parameter.

First we need a table type:

CREATE TYPE dbo.MyTVP (
    empno int not null,
    mydate date not null,
    amt decimal not null
    primary key (empno, mydate)
);

Then we pass it through. You don't necessarily need a stored procedure, you can do this as an ad-hoc batch:

public int UpdateAmount(List<MyTable> myBizObjList)
     {
         var table = new DataTable();
         table.Columns.Add("empno", typeof(int));
         table.Columns.Add("mydate", typeof(datetime));
         table.Columns.Add("amt", typeof(decimal));
         foreach (MyTable myBizObj in myBizObjList)
             table.Rows.Add(myBizObj.Empno, myBizObj.Mydate, myBizObj.Amt);
         
         const string commandText = @"
Update tbl
Set amt = t.amt
FROM MyTable AS tbl
JOIN @tmp AS t ON t.empno = tbl.empno AND t.mydate = tbl.mydate;
";

         using (var cs = db.GetConnection())
         {
             SqlCommand command = new SqlCommand(commandText, cs, sqltxn);
             command.Parameters.Add(
             new SqlParameter("@tmp", SqlDbType.Structured)
             {
                 Direction = ParameterDirection.Input,
                 TypeName = "dbo.MyTVP",
                 Value = table
             });

             cs.Open();
             return command.ExecuteNonQuery();
         }
     }