PHP 花括号替换多个值

Question

I want to place the value lara certain words in curly brackets. But it gives me $ str as a result. So it shows me the word the same without making any replacement.

I try it like follow:

function replace($Str){ 
   preg_match_all('/{(\w+)}/', $Str, $matches);
   $afterStr = $Str;
   foreach ($matches[0] as $index => $var_name) {
     if (isset(${$matches[1][$index]})) {
        $afterStr = str_replace($var_name, ${$matches[1][$index]}, $afterStr); 
     }
   }
     return $afterStr;
}

$value1 = 'Apple';
$value2 = 'Orange';

$text = 'The colors of {value1} and {value2} are different.';

echo replace($text);

The result that the above codes give me

The colors of {value1} and {value2} are different.

But it should be like this:

The colors of Apple and Orange are different.

Can you tell me what I am missing so that I can get the right result?

Thanks in advance..

Answer 1

You regex has { and } metacharacters. You can't match them as is. You either escape it with backslash \ or use preg_quote() .

Your code is pretty verbose with loops. You can pass array of values to replace with array of destination values and str_replace does the job pretty nicely.

<?php

function replace($Str,$values = []){ 
   preg_match_all('/\{(\w+)\}/', $Str, $matches);
   return str_replace($matches[0],$values,$Str);
}

$value1 = 'Apple';
$value2 = 'Orange';

$text = 'The colors of {value1} and {value2} are different.';

echo replace($text,[$value1,$value2]);

You also missed passing $value1 and $value2 to your function. My advice is to pass them in an array if there are multiple values to replace.