对不同的查询使用相同的 mysqli 准备语句？

Question

Throughout some testings; a little question popped up. When I usually code database updates; I usually do this via callbacks which I code in PHP; to which I simply pass a given mysqli connection object as function argument. Executing all queries of for example three queries across the same single connection proved to be much faster than if closing and reopening a DB connection for each query of a given query sequence. This also works easily with SQL transactions, the connection can be passed along to callbacks without any issues.

My question is; can you also do this with prepared statement objects ? What I mean is, considering we successfully established a $conn object, representing the mysqli connection, is stuff like this legit? :

function select_users( $users_id, $stmt ) {

  $sql = "SELECT username FROM users where ID = ?";

  mysqli_stmt_prepare( $stmt, $sql );
  mysqli_stmt_bind_param( $stmt, "i", $users_id );
  mysqli_stmt_execute( $stmt );

  return mysqli_stmt_get_result( $stmt );

}

function select_labels( $artist, $stmt ) {

  $sql = "SELECT label FROM labels where artist = ?";

  mysqli_stmt_prepare( $stmt, $sql );
  mysqli_stmt_bind_param( $stmt, "s", $artist );
  mysqli_stmt_execute( $stmt );

  return mysqli_stmt_get_result( $stmt );

}

$stmt = mysqli_stmt_init( $conn );

$users = select_users( 1, $stmt );
$rappers = select_labels( "rapperxyz", $stmt );

or is it bad practice; and you should rather use:

$stmt_users = mysqli_stmt_init( $conn );
$stmt_rappers = mysqli_stmt_init( $conn );

$users = select_users( 1, $stmt_users );
$rappers = select_labels( "rapperxyz", $stmt_rappers );

During the testing; I noticed that the method by using a single statement object passed along callbacks works for server calls where I call like 4 not too complicated DB queries via the 4 according callbacks in a row.

When I however do a server call with like 10 different queries, sometimes (yes, only sometimes; for pretty much the same data used across the different executions; so this seems to be weird behavior to me) I get the error "Commands out of sync; you can't run this command now" and some other weird errors I've never experienced, like the amount of variables not matching the amount of parameters; although they prefectly do after checking them all. The only way to fix this I found after some research was indeed by using different statement objects for each callback. So, I just wondered; should you actually ALWAYS use ONE prepared statement object for ONE query, which you then may execute N times in a row?

Answer 1

Yes.

The "commands out of sync" error is because MySQL protocol is not like http. You can't send requests any time you want. There is state on the server-side (ie mysqld) that is expecting a certain sequence of requests. This is what's known as a stateful protocol.

Compare with a protocol like ftp. You can do an ls in an ftp client, but the list of files you get back depends on the current working directory. If you were sharing that ftp client connection among multiple functions in your app, you don't know that another function hasn't changed the working directory. So you can't be sure the file list you get from ls represents the directory you thought you were in.

In MySQL too, there's state on the server-side. You can only have one transaction open at a time. You can only have one query executing at a time. The MySQL client does not allow you to execute a new query where there are still rows to be fetched from an in-progress query. See Commands out of sync in the MySQL doc on common errors.

So if you pass your statement handle around to some callback functions, how can that function know it's safe to execute the statement?

IMO, the only safe way to use a statement is to use it immediately.