我在双向链表中的交换代码有问题
[英]I have a problem with swap code in Doubly linked list
问题描述
I made swap code in C but I didn't get perfect grade in school compiler.
我在 C 中制作了交换代码，但我在学校编译器中没有获得完美的成绩。 I think there is a problem with following code.我认为下面的代码有问题。 I made doubly linked list with struct and pointer.我用结构和指针制作了双向链表。 Node is defined that:节点定义为：
struct node* newnode(char x)
{
struct node* new = (struct node*)malloc(sizeof(struct node));
new->next = NULL;
new->prev = NULL;
new->c = x;
return new;
}
And the following code is swap code that I made each function factor mean that "struct node*p" is full list from head to tail, "int a and b" is rank of list and "count1(p)" is function that count node in full list and return number of node (exclude head and tail).下面的代码是交换代码，我使每个 function 因子意味着“struct node*p”是从头到尾的完整列表，“int a and b”是列表的排名，“count1(p)”是 function完整列表中的节点并返回节点数（不包括头部和尾部）。
void swap(struct node* p, int a, int b)
{
int x, y;
struct node* x1, * x2, emp = { 0 };
int i = 0;
x1 = p;
x2 = p;
if (a >= b) {
x = b;
y = a;
}
else {
x = a;
y = b;
}
if (b <= 0 || a <= 0 || a > N || a > count1(p) || b > N || b > count1(p)) {
printf("invalid position\n");
return;
}while (i < x && x1 != tail) {
x1 = x1->next;
i++;
}
i = 0;
while (i < y && p != tail) {
x2 = x2->next;
i++;
}
if (x1->next != x2)
{
x1->prev->next = x2;
x1->next->prev = x2;
x2->prev->next = x1;
x2->next->prev = x1;
emp.next = x1->next;
emp.prev = x1->prev;
x1->next = x2->next;
x1->prev = x2->prev;
x2->next = emp.next;
x2->prev = emp.prev;
}
if (x1->next == x2)
{
emp.prev = x1->prev;
emp.next = x1->next;
x1->prev->next = x2;
x2->next->prev = x1;
x1->prev = x2;
x1->next = x2->next;
x2->prev = emp.prev;
x2->next = x1;
}
}
The following code is my full code:以下代码是我的完整代码：
#include<stdio.h>
#include<stdlib.h>
int N;
struct node {
struct node* next;
struct node* prev;
char c;
};
struct node* head, * tail;
void reset() {
head = (struct node*)malloc(sizeof(struct node));
tail = (struct node*)malloc(sizeof(struct node));
head->prev = NULL;
head->next = tail;
head->c = NULL;
tail->prev = head;
tail->next = NULL;
tail->c = NULL;
}
struct node* newnode(char x)
{
struct node* new = (struct node*)malloc(sizeof(struct node));
new->next = NULL;
new->prev = NULL;
new->c = x;
return new;
}
void prcount(struct node* p)
{
printf("%d\n", count1(p));
}
int count1(struct node* p)
{
int sum = 0;
while (p != tail) {
p = p->next;
sum++;
}
return sum + -1;
}
void add1(struct node* p, int n, char x)
{
struct node* new1 = newnode(x);
int i = 1;
if (n <= 0 || n > N || n > count1(p) + 1) {
printf("invalid position\n");
return;
}
while (i < n && p != tail) {
p = p->next;
i++;
}
p->next->prev = new1;
new1->prev = p;
new1->next = p->next;
p->next = new1;
}
void delete1(struct node* p, int n)
{
int i = 0;
if (n <= 0 || n > N || n > count1(p)) {
printf("invalid position\n");
return;
}
while (i < n && p != tail)
{
p = p->next;
i++;
}
p->prev->next = p->next;
p->next->prev = p->prev;
free(p);
}
void get1(struct node* p, int n) {
int i = 0;
if (n <= 0 || n > N || n > count1(p)) {
printf("invalid position\n");
return;
}while (i < n && p != tail) {
p = p->next;
i++;
}
printf("%c\n", p->c);
}
void print1(struct node* p)
{
int i = 0;
if (count1(p) == 0) {
printf("invalid position\n");
return;
}
while (i < N && p->next != tail)
{
p = p->next;
printf("%c", p->c);
i++;
}
printf("\n");
}void removeall(struct node* p)
{
struct node* emp;
p = p->next;
while (p != tail)
{
emp = p->next;
free(p);
p = emp;
}
head->prev = NULL;
head->next = tail;
head->c = NULL;
tail->prev = head;
tail->next = NULL;
tail->c = NULL;
}
void swap(struct node* p, int a, int b)
{
int x, y;
struct node* x1, * x2, emp = { 0 };
int i = 0;
x1 = p;
x2 = p;
if (a >= b) {
x = b;
y = a;
}
else {
x = a;
y = b;
}
if (b <= 0 || a <= 0 || a > N || a > count1(p) || b > N || b > count1(p)) {
printf("invalid position\n");
return;
}while (i < x && x1 != tail) {
x1 = x1->next;
i++;
}
i = 0;
while (i < y && x2 != tail) {
x2 = x2->next;
i++;
}
if (x1->next != x2)
{
x1->prev->next = x2;
x1->next->prev = x2;
x2->prev->next = x1;
x2->next->prev = x1;
emp.next = x1->next;
emp.prev = x1->prev;
x1->next = x2->next;
x1->prev = x2->prev;
x2->next = emp.next;
x2->prev = emp.prev;
}
if (x1->next == x2)
{
emp.prev = x1->prev;
emp.next = x1->next;
x1->prev->next = x2;
x2->next->prev = x1;
x1->prev = x2;
x1->next = x2->next;
x2->prev = emp.prev;
x2->next = x1;
}
}
int main()
{
int i;
int r, n;
char x, y;
reset();
scanf("%d", &N);
for (i = 0; i < N; i++)
{
scanf(" %c", &x);
if (x == 'A') {//A mean add(head,int a, char x) -> add 'x' on a rank in list
scanf("%d", &r);
scanf(" %c", &y);
add1(head, r, y);
}
else if (x == 'D') {// D mean delete(struct node *head, int a) -> delete element on int a rank
scanf("%d", &r);
delete1(head, r);
}
else if (x == 'G') {//G mean Get(head,int a)-> print element on int a rank
scanf("%d", &r);
get1(head, r);
}
else if (x == 'P') {//P mean print(head) -> print all element in list
print1(head);
}
else if (x == 'R') {//R mean Removeall(head) -> remove all node (exclude head and tail0
removeall(head);
}
else if (x == 'C')//C Mean prcount(head) -> count and print number of node in list (exclude head and tail)
{
prcount(head);
}
else if (x == 'S') {//S mean Swap(head, int a, int b) -> swap element of int a rank with int b rank
scanf("%d", &r);
scanf("%d", &n);
swap(head, r, n);
}
}
removeall(head);
}
It's my full code.这是我的完整代码。 I want to know is there any problem Or more effective way to make swap code?我想知道制作交换代码有什么问题或更有效的方法吗？
2 个解决方案
解决方案1
0 2021-04-02 11:18:58
#include<stdio.h>
#include<stdlib.h>
int N;
struct node {
struct node* next;
struct node* prev;
char c;
};
struct node* head, * tail;
void reset() {
head = (struct node*)malloc(sizeof(struct node));
tail = (struct node*)malloc(sizeof(struct node));
head->prev = NULL;
head->next = tail;
head->c = NULL;
tail->prev = head;
tail->next = NULL;
tail->c = NULL;
}
struct node* newnode(char x)
{
struct node* new = (struct node*)malloc(sizeof(struct node));
new->next = NULL;
new->prev = NULL;
new->c = x;
return new;
}
void prcount(struct node* p)
{
printf("%d\n", count1(p));
}
int count1(struct node* p)
{
int sum = 0;
while (p != tail) {
p = p->next;
sum++;
}
return sum + -1;
}
void add1(struct node* p, int n, char x)
{
struct node * new1 = newnode(x);
int i = 1;
if (n<=0||n > N || n > count1(p) + 1) {
printf("invalid position\n");
return;
}
while (i < n && p != tail) {
p = p->next;
i++;
}
p->next->prev = new1;
new1->prev = p;
new1->next = p->next;
p->next = new1;
}
void delete1(struct node* p, int n)
{
int i = 0;
if (n <= 0 || n > N || n > count1(p)) {
printf("invalid position\n");
return;
}
while (i < n && p != tail)
{
p = p->next;
i++;
}
p->prev->next = p->next;
p->next->prev = p->prev;
free(p);
}
void get1(struct node* p, int n) {
int i = 0;
if (n <= 0 || n > N || n > count1(p)) {
printf("invalid position\n");
return;
}while (i < n && p != tail) {
p = p->next;
i++;
}
printf("%c\n", p->c);
}
void print1(struct node* p)
{
int i = 0;
if (count1(p) == 0) {
printf("invalid position\n");
return;
}
while (i < N && p->next != tail)
{
p = p->next;
printf("%c", p->c);
i++;
}
printf("\n");
}void removeall(struct node* p)
{
struct node* emp;
p = p->next;
while (p != tail)
{
emp = p->next;
free(p);
p = emp;
}
head->prev = NULL;
head->next = tail;
head->c = NULL;
tail->prev = head;
tail->next = NULL;
tail->c = NULL;
}
void swap(struct node* p, int a, int b)
{
int x, y;
struct node* x1, * x2, emp = { 0 };
int i = 0;
x1 = p;
x2 = p;
if (a >= b) {
x = b;
y = a;
}
else {
x = a;
y = b;
}
if (b <= 0 || a <= 0 || a > N || a > count1(p) || b > N || b > count1(p)) {
printf("invalid position\n");
return;
}while (i < x && x1 != tail) {
x1 = x1->next;
i++;
}
i = 0;
while (i < y && p != tail) {
x2 = x2->next;
i++;
}
if (x1->next != x2)
{
x1->prev->next = x2;
x1->next->prev = x2;
x2->prev->next = x1;
x2->next->prev = x1;
emp.next = x1->next;
emp.prev = x1->prev;
x1->next = x2->next;
x1->prev = x2->prev;
x2->next = emp.next;
x2->prev = emp.prev;
}
if (x1->next == x2)
{
emp.prev = x1->prev;
emp.next = x1->next;
x1->prev->next = x2;
x2->next->prev = x1;
x1->prev = x2;
x1->next = x2->next;
x2->prev = emp.prev;
x2->next = x1;
}
}
int main()
{
int i;
int r, n;
char x, y;
reset();
scanf("%d", &N);
for (i = 0; i < N; i++)
{
scanf(" %c", &x);
if (x == 'A') {
scanf("%d", &r);
scanf(" %c", &y);
add1(head, r, y);
}
else if (x == 'D') {
scanf("%d", &r);
delete1(head, r);
}
else if (x == 'G') {
scanf("%d", &r);
get1(head, r);
}
else if (x == 'P') {
print1(head);
}
else if (x == 'R') {
removeall(head);
}
else if (x == 'C')
{
prcount(head);
}
else if (x == 'S') {
scanf("%d", &r);
scanf("%d", &n);
swap(head, r, n);
}
}
removeall(head);
}
it is my full code这是我的完整代码
解决方案2
0 2021-04-02 12:06:55
int N is used as the number of input commands in main . int N用作main中输入命令的数量。 The comparisons with N in your list functions (as if N would denote the number of nodes) make no sense - you could just drop them.与列表函数中的N进行比较（好像N表示节点数）没有任何意义 - 您可以直接删除它们。
Besides that, there are some places where a compiler with appropriate options would issue warnings - perhaps that's why you didnt get perfect grade in school compiler . Besides that, there are some places where a compiler with appropriate options would issue warnings - perhaps that's why you didnt get perfect grade in school compiler .
head->c = NULL;
Since c is of type char and NULL is a null pointer constant this doesn't fit;由于c是char类型，而NULL是null 指针常量，因此不适合； change to改成
head->c = '\0'; // or head->c = 0;
printf("%d\n", count1(p));
There you call count1 before it is declared.在声明之前，您可以在此处调用count1 。 Declare it before use with在使用前声明它
int count1(struct node* p);
or move the function definition before the first function using it.或将 function 定义移到第一个 function 之前使用它。
声明:本站的技术帖子网页，遵循CC BY-SA 4.0协议，如果您需要转载，请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.
相关问题
在双向链接列表中交换项目 - Swap items in a doubly linked list
C，双向链表问题 - C, doubly linked list problem
当我使用双向链表中的最后一个指针时代码崩溃 - code crashes when i use the last pointer in doubly linked list
具有双向链表的多项式 - 指针问题 - Polynominal with doubly linked list - pointer problem
如何在C中的双向链表中交换两个相邻项 - How to swap two adjacent items in a doubly linked-list in C
C语言中的双链表：为什么即使头和尾没有更改，我也必须显式重新分配头和尾？ - Doubly linked list in C: Why do I have to explicitly reassign head and tail even when they are not changed?
在C中删除双向链表中的头节点时出现问题 - Problem deleting head node in a doubly linked list in C
双向链表 - Doubly linked circular list
带字符串的双链表 - Doubly Linked List with strings
没有双向链表 - free of doubly linked list
相关标签