C 代理崩溃

Question

Im writing a program which connects to a browser and sends the http request from the browser to a server, and then sends the response back to the browser, which loads the page with some of the content. My program sends things successfully and loads pages, but does not run continuously and will crash after a random amount of time- sometimes 10 seconds of running sometimes 1 minute. I want this proxy to be able to run forever. Below is how I have structured my code. I have included the recv and write section which I think is causing my errors in full. I am pretty new to socket programming and c In general and looking for some tips on my structure and anything I may have missed.

int main(int argc, char *argv[])
{
    char ip[40]
    char *host = argv[1];
    char *port_s = argv[2];
    int err;                             
    int socket_browser, socket_newBrowser, c;
    struct sockaddr_in server, client;
    int n;

    socket_browser= socket(AF_INET, SOCK_STREAM, 0);
    if (socket_browser < 0)
    {
        printf("Could not create socket");
    }

    if (err = bind(socket_browser , (struct sockaddr *)&server, sizeof(server)) != 0)
    {
        resourceError(err, "bind");
        return 1;
    }

    if (err = listen(socket_browser , 3) != 0)
    {
        resourceError(err, "listen");
    }

while (1){

        c = sizeof(struct sockaddr_in);
        server_socket= accept(socket_browser, (struct sockaddr *)&client, (socklen_t *)&c);

       char buf[256];
       int n;

       n = recv(socket_newBrowser, buf, 256, 0);
       if (n < 0){
          resourceError(n,"recv");
       }

      int server_socket;
      struct sockaddr_in server2;

       server_socket= socket(AF_INET, SOCK_STREAM, 0);
        if (server_socket < 0)
        {
            resourceError(server_socket, "serverSocket");
        }
        server2.sin_addr.s_addr = inet_addr(ip);
        server2.sin_family = AF_INET;
        server2.sin_port = htons(80);

       connect(server_socket, (struct sockaddr *)&server2, sizeof(server2))
       send(server_socket, buf, strlen(buf), 0);

      char reply[256];
      int bytes_reply = 0;

    do
            {
                bytes_reply = recv(server_socket, reply, sizeof(reply), 0);
                // Need to check for double enter as this currently does not work in telnet
                if (bytes_reply == -1)
                {
                    perror("Recv error");
                }
                else
                {
                    write(server_socket, reply, bytes_reply);
                }
            } while (bytes_reply > 0);


        printf("connections closed");
    }
    return 0;
}

Answer 1

I think your problem (or at least a problem) is:

n = recv(socket_newBrowser, buf, 256, 0);
/*versus*/
send(server_socket, buf, strlen(buf), 0);

buf is not null-terminated, you should have used the n value returned from recv instead of strlen .