c，CS50 拼写代码中 fscanf 循环的分段错误

Question

I'm doing the cs50 speller problem and it seems everything is working except when I run Valgrind it says there is a segmentation fault, when I try running the code the same error also occurs. This is an exercise from cs50 where I have a function which takes a "dictionary" file, which is read word by word by a loop and stored in a hashtable, to read each word, I used a while loop using fscanf taking a string from the pointer of the dictionary, to a string called words (which is bigger than any word on the dictionary), the loop keeps running until reaching EOF:

//Puts dictionary words into hashtable

bool load(const char *dictionary)
{
    // TODO
    FILE *dictionaryPointer = fopen(dictionary,"r");
    if (dictionaryPointer == NULL)
    {
        printf("Not enough memory or not found %s \n", dictionary);
        return false;
    }
    //LENGTH is 45, the maximum amount of letters in a word.
    char words[LENGTH + 1];
    //Here is the segmentation fault problem
    while( fscanf(dictionaryPointer, "%s", words) != EOF)
    {
        node *n = malloc(sizeof(node));
        if (n == NULL)
        {
            printf("Not enough memory in node. \n");
            return false;
        }
        strcpy(n->word, words);
        int hashValue = hash(n->word);
        n->next = table[hashValue];
        table[hashValue] = n;
        sizeDictionary++;
    }
    fclose(dictionaryPointer);
    return true;
}

Answer 1

Looks like your hash function is returning an index that's out of bounds. table[hashValue] If hashvalue is greater than the size of table, then this will seg fault.

If you change the return statement in your hash function to something like return hashvalue % N; where N is the number of items table, that should fix it.