高效查询多张表c# linq

Question

I have a database with about 20 table, all of them have some columns which are same, eg, name, cost, year manufactured etc. I need to query those tables. what is best, most efficient way. tables and data have to stay as they are.

Here is what I am doing right now.

var table1 = (from a in _entities.ta1
              join b in _entities.subTa on a.tid equals b.Id
              select new
                     {
                         id = a.id,
                         name = a.name,
                         type = a.type,
                     }).ToList();
var table2 = (from a in _entities.ta2
              join b in _entities.subTa2 on a.tid equals b.Id
              select new
                     {
                         id = a.id,
                         name = a.name,
                         type = a.type,
                     }).ToList();

var abc = table1;
abc.AddRange(table2)

var list = new List<MyClass>();

foreach(var item in abc)
{
      var classItem = new MyClass();
      classItem.id = item.id;
      classItem.name = item.name;
      classItem.type = item.type;

      list.Add(classItem);
}

return list;

This needs to be done to many table, which is not very efficient coding.

How can I improve this code?

Answer 1

You could use that, assuming that data types for all columns do match.

List<MyClass> list =
    ( //table1
     from a in _entities.ta1
     join b in _entities.subTa
     on a.tid equals b.Id
     select new MyClass()
     {
         id = a.id,
         name = a.name,
         type = a.type
     })
    .Concat(( //table2 (use .Union instead of .Concat if you wish to eliminate duplicate rows)
     from a in _entities.ta2
     join b in _entities.subTa2
     on a.tid equals b.Id
     select new MyClass()
     {
         id = a.id,
         name = a.name,
         type = a.type
     }
    )).ToList();
return list;

The reason why this could be more efficient is that it

1. groups all queries into one database query, thus causes less database traffic,
2. lets all the computation happen on the database server, therefore eliminating duplicate computation in the OP code, and
3. optimizes memory usage as it does NOT create a list of anonymous objects and then adding them to a new List<MyClass> .

Answer 2

This is the answer i was looking or. this is not ideal but it got the job done

 var tables= new Dictionary<string, string>();
 tables.Add("table1", "subTable1");
 tables.Add("table2", "subTable2");
 foreach (var table in tables)
            {
                var tableName = table.Key;
                var subName= table.Value;
                var data = _entities.Database.SqlQuery<MyClass>($@"select 
                a.Id,a.Name,b.subName from {tableName} a  left join {subName} b on 
                a.subId=b.Id").ToList();
            }

Thank you everyone for your contribution