将过滤器与 vainilla JS 结合使用，逻辑问题

Question

I'm practising with DOM manipulation, APIs and filters; I am creating a table with JavaScript, I've created some checkboxes and a drop-down to filter the data, and now trying to combining both.

So far, I managed to make it work for 3 out of the 4 possible cases, but I don't see what I am missing on the fourth.

This my filtering function:

function filtering(data, optionChecked, harvestTypeValue) {
  let filteredResults = [];
  if (optionChecked.length === 0 && harvestTypeValue === 'all') {
    // No checkboxes checked and dropdown with option "All" selected. Working
    filteredResults = data
  } else if (optionChecked.length === 0 && harvestTypeValue != 'all') {
    for (let i = 0; i < data.length; i++) {
      if (data[i]['Harvest Type'] == harvestTypeValue) {
        // No checkboxes checked and dropdown with any option selected. Working:
        filteredResults.push(data[i]);
      }
    }
  } else if (optionChecked.length != 0 && harvestTypeValue === 'all') {
    for (let i = 0; i < data.length; i++) {
      if (optionChecked.includes(data[i]['NOAA Fisheries Region'])) {
        // Any checkbox checked and dropdown with All. Working:
        filteredResults.push(data[i]);
      }
    }
  } else {
    for (let i = 0; i < data.length; i++) {
      if (filteredResults.includes(data[i]['NOAA Fisheries Region']) && data[i]['Harvest Type'] == harvestTypeValue) {
        // Any/some checkboxes checked and dropdown with any option selected. NOT working.
        // Getting an empty object:
        filteredResults.push(data[i]); 
      }
    }
  }
  createTable(filteredResults)
}

It might be a small thing, or a big fail in my logic, but I am clueless and almost giving up.

I would also appreciate any suggestions to make that code shorter.

Answer 1

last Else , instead of

if (filteredResults.includes(data[i]['NOAA Fisheries Region']) && data[i]['Harvest Type'] == harvestTypeValue)

should be :

if (optionChecked.includes(data[i]['NOAA Fisheries Region']) && data[i]['Harvest Type'] == harvestTypeValue)

Now it makes sense and both filters work combined in all possible ways

amazing how blind (and stupid) I was...

Thanks to all!