它说我在我的列中插入了太多的值，而我不是？

Question

I am creating a login menu and I put in the details:

Username:test2
Email:Test2
Password: testPassword
Confirm Password: testPassword

The confirm password must be the same as password for it to go into the database so it would be one value

then i get the error:

System.Data.SqlClient.SqlException: 'Invalid column name 'test2test2testPassword'. There are more columns in the INSERT statement than values specified in the VALUES clause. The number of values in the VALUES clause must match the number of columns specified in the INSERT statement.'

Could someone help?

Answer 1

Multiple problems in your code:

1. You should use parameters in your queries: https://docs.microsoft.com/en-us/dotnet/api/system.data.sqlclient.sqlcommand.parameters?view=dotnet-plat-ext-5.0
2. The values should be comma separated: Best way to store password in database

insert into RegisterTable(RegUsername, RegEMail, RegPassword)
                   Values('test2','test2','testPassword')

3. Never store unhashed passwords in your database

Answer 2

The comments covered it pretty well but you are missing seperation between your values in your query on top of that you should not trust user entered text and use it directly in to queries

you should used paramatized commands like this

var checkCount =
    new SqlCommand("insert into [TableName] (id, othercolumn) VALUES(@id, @otherColumn)",
                    conn);
checkCount.Parameters.AddWithValue("@id", id);
checkCount.Parameters.AddWithValue("@otherColumn", otherColumn);