Malloc在分配内存时返回无效大小错误

Question

I have this function for forming a HTTP request string. When running, malloc returns an error:

malloc(): invalid size (unsorted) Aborted

Below is the function I created, cannot understand why this is returning an error.

char* integration_request(char* function, char* lower, char* upper,
        char* segments, char* threads) {

char* start = "GET /integrate/";
char* bs = "/";
char* end = "HTTP/1.1\n\n";
char* request = malloc(sizeof(char) * strlen(start + 1));
strcpy(request, start);

strcat(request, lower);
strcat(request, bs);

strcat(request, upper);
strcat(request, bs);

strcat(request, segments);
strcat(request, bs);

strcat(request,threads);
strcat(request,bs);

strcat(request,function);
strcat(request, end);

return request;
}

Answer 1

You are allocating too little memory. Try:

char* request = malloc(strlen(start) +
                       strllen(lower) +
                       strllen(bs) +
                       strllen(upper) +
                       strllen(bs) +
                       strllen(segments) +
                       strllen(bs) +
                       strllen(threads) +
                       strllen(bs) +
                       strllen(function) +
                       strllen(bs) +
                       1);

Notice that sizeof(char) is always 1 so you don't need to write that.