通过在不使用任何预写函数的情况下反转堆栈来检查单词是否为回文

Question

#include <iostream>
#include <string>
using namespace std;
#define Max 100000
class Stack {
private:
    int top =-1;
    char letters[Max];

public:
    void setTop(int t) {
        top = t;
    }
    int getTop() {
        return top;
    }
    bool isEmptyStack() {
        if (top == -1) {
            return true;
        }
        else{ return false;
    }

   }

    char push(char x,int s) {
        if (top != s - 1){
            top++;
            x = letters[top];
            return x;
        }
       
    }
    char pop() {
        if ((isEmptyStack())==false){
            cout << "the deleted value is: " << l[top]<<endl;
            top--;
            return l[top];
        }


    }
   
 
};
void reverse(char letters[], char temp[], int size, Stack stack) {
    int i=0;
    for (i = 0; i < size; i++) {
        stack.push(letters[i],size);
    }
    i = 0;
    cout << temp<<endl;
    while (stack.isEmptyStack() == false)
    {
        letters[-1] = stack.getTop();
        stack.pop();
        stack.push(letters[i],size);
        i++;
    }
     /*   for (int i = 0; i < size; i++) {
            cout << temp[i];
        }*/
}


int myStringLength(const char* letter)
{
    for (int i = 0, c = 0; letter[i] != '\0'; i++, c++) {

        if (letter[i] != '\0')
            for (; letter[i] != '\0'; i++, c++)
                if (letter[i] == '\0') break;
        return c;
    }
}
int main()
//initializes the main function
{
    Stack stack;
    string w;
    std::cout << "Enter a Word: ";
    getline(cin,w);


    char* letters = &w[0];
    // sets the character text array to set the number of characters equal to the size of the string
   
    //calls the processData function 
    
    std::cout << letters<<endl;
     int size = myStringLength(letters);
    reverse(letters, letters, size, stack);




    return 0;//returns the function at 0.
}

I set out to create a program that will check if a word is a palindrome(meaning it is spelled the same normally and if the word is reversed.) I am not yet at that point that is just the final objective. In my code, I have created a stack class because I wanted to feel the satisfaction of getting the same result using my own code. My problem is the stack is not reversing it is returning some weird characters that I don't have the keys on my keyboard to replicate. The desired outcome should be word's reversed characters. if the word is food the function should be returning doof . I have already compared the reversed stack to the original and printed the final statement. I fixed the char letters[];

Answer 1

If you're open to using a simple function instead of a Stack then you could use the following program since it is much more simple than your Stack version and hence less-error prone .

#include <iostream>
#include <string>
bool checkIfPalindroom(const std::string &str)
{
    for(int i=0;i<(str.size()/2);i++)
    {
         if (str[i] != str[str.size() - i - 1])
         {
             return false;//if this if is satisfied even once, return false
         }
    
    }
    return true;//if the control flow reaches here this will mean that no if was satisfied and hence return true
}
int main()
{
    std::string myString = "Somearbitrarystring";
    
    
    if(checkIfPalindroom(myString))//call the function
    {
        std::cout<<"The given string: "<<myString <<" is a palindrome"<<std::endl;
    }
    else 
    {
        std::cout<<"The given string: "<<myString<<" is not a palindrome"<<std::endl;
    }

    return 0;
}