从 (int) 到 (short) 错误的无效缩小转换

Question

I am getting an error with both (short)m_nScreen.

This is code to create a console window, and whenever I try and run it, I get errors. The error I get is "invalid narrowing conversion from (int) to (short)"

        m_rectWindow = { 0, 0, (short)m_nScreenWidth - 1, (short)m_nScreenHeight - 1 };

Answer 1

(short)m_nScreenHeight - 1 narrows m_nScreenHeight only to widen it again prior to the subtraction with 1, which is an int - thus an useless narrowing. @MM .

Instead, subtract and then narrow the difference.

// (short)m_nScreenHeight - 1
(short)(m_nScreenHeight - 1)

Same for m_nScreenWidth .