AsyncTask/doInBackground 未执行

Question

I'm trying to create an app that queries a site of cat images, saves them to the android device if the JSON ID is unique, and then display them from the device in a slideshow format. Despite everything my AsyncTask doesn't seem to actually be executing. Debugger confirms a network connection is established and doesn't feed me back any errors so I have no idea what's wrong with my code. Hoping someone can help! Code is below:

package com.example.lab2;

import androidx.appcompat.app.AppCompatActivity;
import androidx.loader.content.AsyncTaskLoader;

import android.content.Context;
import android.content.ContextWrapper;
import android.graphics.Bitmap;
import android.graphics.BitmapFactory;
import android.media.Image;
import android.os.AsyncTask;
import android.os.Bundle;
import android.os.Handler;
import android.os.Looper;
import android.provider.MediaStore;
import android.util.Log;
import android.widget.ImageView;
import android.widget.ProgressBar;

import org.json.JSONException;
import org.json.JSONObject;

import java.io.BufferedReader;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.net.HttpURLConnection;
import java.net.URL;
import java.sql.Array;
import java.util.ArrayList;
import java.util.concurrent.Executor;
import java.util.concurrent.Executors;

public class MainActivity extends AppCompatActivity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        CatImages req = new CatImages();
        req.execute();
    }

    class CatImages extends AsyncTask<String, Integer, String> {

        ArrayList<String> ids = new ArrayList<String>();

        ContextWrapper cw = new ContextWrapper(getApplicationContext());
        Bitmap images;
        String id;
        ImageView imageView = findViewById(R.id.imageView);
        ProgressBar progressBar = findViewById(R.id.progressBar);
        File directory = cw.getDir("imageDir", Context.MODE_PRIVATE);
        boolean on = true;

        @Override
        protected String doInBackground(String... strings) {

            while(on == true) {
                try {
                    URL url = new URL("https://cataas.com/cat?json=true");
                    HttpURLConnection urlConnection = (HttpURLConnection) url.openConnection();
                    InputStream response = urlConnection.getInputStream();

                    BufferedReader reader = new BufferedReader(new InputStreamReader(response, "UTF-8"), 8);
                    StringBuilder builder = new StringBuilder();

                    String line = null;
                    while ((line = reader.readLine()) != null)
                    {
                        builder.append(line + "\n");
                    }
                    String result = builder.toString();
                    JSONObject image = new JSONObject(result);
                    id = image.getString("id");
                    ids.add(id);

                    for (String element : ids) {
                        if (element.contains(id)) {

                            return null;

                        } else {

                            images = BitmapFactory.decodeStream(response);
                            File path = new File(directory, id + ".jpg");
                            FileOutputStream outputStream = new FileOutputStream(path);
                            images.compress(Bitmap.CompressFormat.PNG, 100, outputStream);
                            outputStream.flush();
                            outputStream.close();
                            ids.add(id);

                        }
                    }

                    for (int i = 0; i < 100; i++) {
                        try {
                            publishProgress(i);
                            Thread.sleep(30);
                        } catch (Exception e) {
                            e.printStackTrace();
                        }
                    }


                } catch (IOException | JSONException e) {
                    return null;
                }

            }
            return null;
        }

        @Override
        protected void onProgressUpdate(Integer... values) {
            super.onProgressUpdate(values);

            for(String element : ids) {
                if(element.contains(id)) {

                    File openedPic = new File(directory, id + ".jpg");
                    try {
                        Bitmap opener = BitmapFactory.decodeStream(new FileInputStream(openedPic));
                        imageView.setImageBitmap(opener);
                    } catch (FileNotFoundException e) {
                        e.printStackTrace();
                    }

                }
            }
        }

        @Override
        protected void onPostExecute(String fromDoInBackground) {
            super.onPostExecute(fromDoInBackground);
        }
    }
}

Answer 1

Try changing !=null to ==null in your second while loop.

Also you just need while(on) in your first while loop.

Let me know if anything changes.