如果没有等待 HttpClient().GetAsync().Result.Content.ReadAsStringAsync().Result 有什么问题吗？

Question

Any issue with this C# method (.Net Framework 4.8) with not having await? I am using ReadAsStringAsync() with no await. Caller of RetrieveContent() method can't call it asynchronously. So, I need to avoid making it async method. This is a Windows Console app that can also be installed as a Windows Service- with an endpoint listening for requests. It is supposed to do Synchronous processing- one request at a time.

public string RetrieveContent()
{
  return new HttpClient().GetAsync("https://www.google.com").Result.Content.ReadAsStringAsync().Result;
}

OR

public string RetrieveContent()
{
  var response = new HttpClient().GetAsync("https://www.google.com").Result;
  return response.Content.ReadAsStringAsync().Result;
}

Updates: I can change like this. Thus, caller to this method doesn't need an information from Async method. Will this cause a dead-lock too?

public void RetrieveContent()  //this is just logging content
{
  var response = new HttpClient().GetAsync("https://www.google.com").Result;

  if (response.StatusCode == HttpStatusCode.OK)
    _logger.LogInformation($"content: {response.Content.ReadAsStringAsync().Result} ");  //_logger is logging to local disk I/O
  else 
    _logger.LogError($"HttpStatusCode: {response.StatusCode} ");
}
'''

Answer 1

Calling Result from synchronous code blocks is considered unsafe and may cause deadlocks because the task might depend on other incomplete tasks. Instead, you should usually be striving to make caller methods async as much as possible. In this specific case, however, it may be okay with a Task.Run wrapper.

See this question for more details: What's the "right way" to use HttpClient synchronously?

Answer 2

Math.Floor. If it doesnt work try to sort the array! Silly beginner mistake!