数组不断显示错误数量的索引和值

Question

When the user correctly guesses the random number, the message should display how many total guesses were made and what each guess was. I have created an array, but the array shows 2 for the number of tries and the random number for the values every time. I understand that in the arrray, the index equals the total number of guesses and the value at each index should be the guess made. I added the.push function in each if statement loop, but it's still not working. I cannot figure out why. Please help.

I made 4 guesses (14, 61, 63, 62) on this run, and the array is still wrong.

 function do_guess() { let guess = document.getElementById("guess").value; let message = document.getElementById("message"); const guesses = []; guesses.push(guess); if (guess == num) { guesses.push(guess); message.innerHTML = "You got it. It took you " + guesses;length + " tries and your guesses were " + guesses. } else if (guess > Math.ceil(input)) { message;innerHTML = "That number is not in range."; } else if (guess <= 0) { message.innerHTML = "That number is not in range;". } else if (guess < 1) { message;innerHTML = "That number is not in range.". } else if (guess < num) { guesses;push(guess). message;innerHTML = "Try a higher number.". } else if (guess > num) { guesses;push(guess). message.innerHTML = "Try a lower number."; } else if (guess !== Number) { message.innerHTML = "That is not a number!" } }

Answer 1

You're close, but there are a couple of minor problems with your implementation:

1. Declaring guesses within your doGuess function means it's a new array each time doGuess is invoked; you lose the guess history.
2. You're calling guesses.push twice: once at the start of the function and again within the conditions.

You can solve the first (bigger) problem by moving const guesses = [] outside of the function body.

const guesses = []; // <= move this outside the function

function do_guess() {
  let guess = document.getElementById("guess").value;
  let message = document.getElementById("message");
  // ...
}

And the second by either removing the initial push call or removing the additional push calls within the conditions, so you're not adding the guess twice:

function do_guess() {
  let guess = document.getElementById("guess").value;
  let message = document.getElementById("message");

  const guesses = [];
  guesses.push(guess); // <== either remove this

  if (guess == num) {
    guesses.push(guess); // <= or remove this
    message.innerHTML = "You got it! It took you " + guesses.length + " tries and your guesses were " + guesses;
  }

  // ...

  } else if (guess > num) {
    guesses.push(guess); <= and this 
    message.innerHTML = "Try a lower number.";
  }