如何仅在值不为空的情况下添加对象属性

Question

I have to add new functionality to add some metadata when the referral variable is not empty. I've made this, but something in me is saying that this could be done simpler.

async createStripeCustomer(user, refferal) {
    if (refferal) {
      return stripe.customers.create({
        email: user.email,
        metadata: {
          userId: user.id,
          referral: refferal,
        },
      });
    } else {
      return stripe.customers.create({
        email: user.email,
        metadata: {
          userId: user.id,
        },
      });
    }
  }

Answer 1

You can reduce the duplication like the code below

 async createStripeCustomer(user, refferal) { const customer = { email: user.email, metadata: { userId: user.id, }, }; if (refferal) { customer.metadata.refferal = refferal; } return stripe.customers.create(customer); }

Answer 2

From memory of the Stripe API, null values in metadata will not set that variable in the metadata.

So you can just do...

async createStripeCustomer(user, refferal) {
    return stripe.customers.create({
        email: user.email,
        metadata: {
            userId: user.id,
            referral: (refferal ? refferal : null)
        },
    });
}