setTimeout（）不执行

Question

I've got this simple function which displays a message to the user. If I add the timeout parameter it will slide back up automatically if not the user has to click it to get rid. But the timeout bit isn't working.

function feedback(text, timeout){
    $('#feedback').text(text).slideDown('fast');

    $('#feedback').click(function(){
        $(this).slideUp();
    });
    if(timeout){
        setTimeout(function(){
            $('#feedback').slideup();
        }, timeout);
    }
}

Answer 1

The problem is that $('#feedback').slideup(); needs a capital U in there (eg .slideUp() ). You can also shorten it down a bit overall doing this:

function feedback(text, timeout){
    var fb = $('#feedback').text(text).slideDown('fast');
    if(timeout) fb.delay(timeout).slideUp();

    fb.click(function(){
        $(this).slideUp();
    });
}

This uses the built-in delay() functionality of jQuery to achieve the same effect in a more concise way.

Answer 2

putting a whole function call inside a set timeout function is not valid. Your setTimeout will never trigger as you might want it to, as setTimeout will only accept a function reference.

setTimeout(function(){
  $('#feedback').slideup();
}, timeout);

Try the following code:

var ref = function() {
  $('#feedback').slideup();
};
setTimeout(ref, timeout);