BASH 中带空格的文件名

Question

I'm trying to write script that'll crop and resize large photos into HD Wallpapers.

#! /bin/bash


for i in `ls *.jpg`
do
    width=`identify -format '%w' $i`
    height=`identify -format '%h' $i`

    if [ `echo "$width/$height > 16/9" | bc -l` ]
    then
        exec `convert $i -resize 1920 -gravity Center -crop '1920x1080+0+0' +repage temp`
    else
        exec `convert $i -resize x1080 -gravity Center -crop 1920x1080+0+0 +repage temp`
    fi

    rm $i
    mv temp $i
done

But it seems that the script has problems with file names having spaces (like Tumble Weed.jpg). How can I fix this?

Answer 1

First, you don't need ls . By using ls in backtics, you implicitly make bash parse a string into a list, which splits by whitespaces. Instead, make bash generate the list and separate it without such quirks:

Also, you need to enclose all $i usages into quotes, to make bash substitute it as a whole, not as a string split to separate words.

Here's the script that demonstrates both ideas:

for i in *.jpg ; do 
  echo "$i";
done

Answer 2

Use read to circumvent the problem with spaces. It looks a bit unnatural to write the loop like this but it works better:

find . -type f -iname "*.jpg" | while read i
do
    # your original code inside the loop using "$i" instead of $i
done

with -iname you also get the jpg files that might have an extension with different casing like .JPG. "i" in "iname" means ignore casing.

Answer 3

I would recommend to write the for-line like this:

for i in *.jpg

and encapsulate $i in double-quotes: "$i" .

---

If you insist on the

`ls *.jpg`

style, (if you for instance get your file-names from a more complex command) you could try setting IFS to \\n :

IFS='\n'

Compare these two executions:

$ for f in `ls *`; do echo $f; done
hello
world
test

$ IFS='\n'; for f in `ls *`; do echo $f; done
hello world
test

Answer 4

In bash, use string replacement with find :

${string//substring/replacement}
Replace all matches of $substring with $replacement .

so this works:

find . -type f -name '*.jpg' | while read i ; do /bin/mv -f "$i" ${i// /_}; done

Answer 5

Use double quotes around file names. Like this:

width=`identify -format '%w' "$i"`

Please note the double quotes around "$i" .

Answer 6

 #! /bin/bash 
 mkfifo ./lsOutput
 ls -1 *.jpg > ./lsOutput
    while read line  
    do 

    width=`identify -format '%w' "$line"` 
    height=`identify -format '%h' "$line"` 

    if [ `echo "$width/$height > 16/9" | bc -l` ] 
    then 
        exec `convert "$line" -resize 1920 -gravity Center -crop '1920x1080+0+0' +repage temp` 
    else 
        exec `convert "$line" -resize x1080 -gravity Center -crop 1920x1080+0+0 +repage temp` 
    fi 

    rm "$line"
    mv temp "$line"
 done<./lsOutput

Answer 7

I forgot to add the link if you want to download as txt file

or just copy and paste this text as needed

FIRST INSTALL

apt-get install chromium-browser

apt-get install omxplayer

apt-get install terminator

apt-get install nano (if not already installed)

apt-get install zenity (if not already installed)

THEN CREATE A BASH SCRIPT OF ALL OF THESE PERSONALLY WRITTEN SCRIPTS.

MAKE SURE THAT EVERY SHELL SCRIPT IS A .sh FILE ENDING EACH ONE OF THESE IS SCRIPTED TO OPEN UP A DIRECTORY FOR YOU TO FIND AND PICK WHAT YOU WANT.

IT RUNS A BACKGROUND TERMINAL & ALLOWS YOU TO CONTROL THE SONG OR MOVIE.

MOVIE KEYS ARE AS FOLLOWS; p or space bar for pause, q for quit, - & + for sound up and down, left arrow and right arrow for skipping forward and back.

MUSIC PLAYER REALLY ONLY HAS A SKIP SONG AND THAT IS CTRL+C AND IF THAT IS THE LAST SONG OR ONLY SONG THEN IT SHUTS DOWN AND THE TERMINAL GOES AWAY.

****INSTRUCTIONS TO MAKE THE SCRIPTS****

• OPEN UP A TERMINAL

• CD TO THE DIRECTORY YOU WANT THE SCRIPTS TO BE

  cd /home/pi/Desktop/

• OPEN UP THE NANO EDITOR WITH THE TITLE OF SHELL YOU WANT

  sudo nano Movie_Player.sh

• INSIDE NANO, TYPE OR COPY/PAST (REMEMBER THAT IN TERMINAL YOU NEED TO CTRL+SHIFT+V) THE SCRITP

• SAVE THE DATA WITH CTRL+O

  ctrl+o

• HIT ENTER TO SAVE AS THAT FILE NAME OR DELETE THE FILE NAME THEN TYPE NEW ONE JUST MAKE SURE IT ENDS IN .sh THEN HIT ENTER

• NEXT YOU NEED TO SUDO CHMOD IT WITH +X TO MAKE IT CLICKABLE AS A BASH

  sudo chmod +x Movie_Player.sh

• FINALLY RUN IT TO TEST EITHER BY DOUBLE CLICKING IT AND CHOOSING "EXECUTE IN TERMINAL" OR BY ./ IT IN TERMINAL

  ./Movie_Player.sh

YOU ARE NOW GOOD TO PICK A MOVIE OR SELECT A SONG OR ALBUM AND ENJOY!

**** ALL OF THESE SCRIPTS ACCOUNT FOR SPACES IN THE FILENAME

SO YOU CAN ACCESS "TOM PETTY" OR "SIXTEEN STONE" WITHOUT NEEDING THE " _ " BETWEEN THE WORDS.

-------WATCH A MOVIE SCRIPT ------- (

#!/bin/bash

FILE=`zenity --title "Pick a Movie" --file-selection`

for FILE in "${FILE[0]}"

do
     omxplayer "${FILE[0]}"
done

--------LISTEN TO A SONG -------

#!/bin/bash

FILE=`zenity --title "Pick a Song" --file-selection`

for FILE in "${FILE[0]}"

do
     play "${FILE[0]}"
done

--------LISTEN TO AN ALBUM ---------- SONGS IN ORDER

#!/bin/bash

DIR=`zenity --title "Pick a Album" --file-selection --directory` 

for DIR in "${DIR[0]}"

do
  cd "${DIR[0]}" && find . -type f -name '*.ogg' -o -name '*.mp3' | sort --version-sort | while read DIR; do
  play "$DIR"
  done
done

--------LISTEN TO AN ALBUM WITH SONGS IN RANDOM ORDER --------

#!/bin/bash

DIR=`zenity --title "Pick a Album" --file-selection --directory` 

for DIR in "${DIR[0]}"

do
  cd "${DIR[0]}" && find . -type f -name '*.ogg' -o -name '*.mp3' | while read DIR; do
  play "$DIR"
  done
done