按Rails 3中的虚拟属性排序

Question

BACKGROUND: I have a set of Posts that can be voted on. I'd like to sort Posts according to their "vote score" which is determined by the following equation:

( (@post.votes.count) / ( (Time.now - @post.created_at) ** 1 ) )

I am currently defining the vote score as such:

  def vote_score(x)
   ( (x.votes.count) / ( (Time.now - x.created_at) ** 1 ) )
  end

And sorting them as such:

@posts = @posts.sort! { |a,b| vote_score((b) <=> vote_score((a) }

OBJECTIVE: This method takes a tremendous toll on my apps load times. Is there a better, more efficient way to accomplish this kind of sorting?

Answer 1

If you are using MySQL you can do the entire thing using a query:

SELECT   posts.id,
         (COUNT(votes.id)/(TIME_TO_SEC(NOW()) - TIME_TO_SEC(posts.created_at))) as score
FROM     posts INNER JOIN votes ON votes.post_id = posts.id
GROUP BY posts.id
ORDER BY score DESC

Or:

class Post
  scope :with_score, select('posts.*')
    .select('(COUNT(votes.id)/(TIME_TO_SEC(NOW()) - TIME_TO_SEC(posts.created_at))) as score')
    .joins(:votes)
    .group('posts.id')
    .order('score DESC')
end

Which would make your entire query:

@posts = Post.with_score.all

PS: You can then modify your Post class to use the SQL version of score if it is present. You can also make the score function cached in an instance so you don't have to re-calculate it every time you ask for a post's score:

class Post
  def score
    @score ||= self[:score] || (votes.count/(Time.now.utc - x.created_at.utc)
  end
end

PS: The SQLLite3 equivalent is:

strftime('%s','now') - strftime('%s',posts.created_at)

Answer 2

1. You shouldn't use sort! if you are going to assign to the same variable (it is wrong in this case), you should change the sort to:

    @posts.sort!{|a, b| vote_score(b) <=> vote_score(a) } 

2. It looks like you are counting the votes for Post each time you call another Post which is hitting the database quite a bit and probably the source of the toll on your load times, you can use a counter_cache to count each time a vote is made and store that in the posts table. This will make it so you only do one db query to load from the posts table.

http://guides.rubyonrails.org/association_basics.html