将这个数据库结果传递给javascript函数的正确方法是什么？

Question

I am grabbing a string from a "title" field and passing it to an addText javascript function. I am having trouble passing the string properly though. This--->

while ($row = mysql_fetch_assoc($part_result)){

 echo "<div id ='link' onclick = 'addText("$row['title']");'>" . $row['title'] ."</div>";

}

yields a syntax error. Parse error: syntax error, unexpected T_VARIABLE, expecting ',' or ';'

Thanks for your help!

Answer 1

echo "<div id ='link' onclick = 'addText(\"".$row['title']."\");'>" . $row['title'] ."</div>";

Answer 2

You error is coming from the fact that you're not properly concatenating your static strings to your variables in all places.

echo "<div id ='link' onclick = 'addText("$row['title']");'>" . $row['title'] ."</div>";

Should be

echo '<div id="link" onclick="addText( \'' . $row['title'] . '\' );">' . $row['title'] . '</div>';

Also, since $row['title'] is being used inside of an HTML attr, it should be entitized to avoid quote collisions:

echo '<div id="link" onclick="addText( \'' .htmlentities( $row['title'], ENT_QUOTES ) . '\' );">' . $row['title'] . '</div>';

And for the cleanest code I'd use printf() :

printf( '<div id="link" onclick="addText( \'%s\' );">%s</div>', htmlentities( $row['title'], ENT_QUOTES ), $row['title'] );

Answer 3

Try this :

echo '<div id="link" onclick="addText(\''.$row['title'].'\')">'.$row['title'].'</div>';

You don't need the ; after addText()

Answer 4

Use json_encode to pass your title through. This will encode it just in case you have single or double quotes (or any other bad character) in it.

Also your error is coming from the variable itself. Since your are using double quotes, wrap your variable with curly brackets:

addText('{$row['title']}');