我无法弄清的mysql错误

Question

I am trying to insert data to my table:

 $userName="NewOrder";//use cookie to get name;
     $selectCurrentUser=" SELECT user_id FROM users WHERE user_name='$userName'; ";




  mysql_query(" INSERT INTO threads (topic ,date ,views ,user_id ,responses ,closed ,title ,close_voted ,content)
          VALUES('$threadTopic', NOW(), 0, '$selectCurrentUser', 0, 'false', '$threadTitle', 0, '$threadContent');") or die(mysql_error());

      mysql_close();

There is a mistake in my second statement. It says:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'NewOrder'; ', 0, 'false', '11111111111111111111111', 0, ' 22222222222222222222' at line 2

My table structure:

פעולה thread_id int(11) None AUTO_INCREMENT
topic varchar(50)
date date None
views int(11) None
user_id int(11) None
responses int(11) None
closed varchar(10) utf8_unicode_ci None
title varchar(100) utf8_unicode_ci None
close_voted int(11) None
content text utf8_unicode_ci None

Answer 1

Instead of '$selectCurrentUser' , use ($selectCurrentUser) . Also, I don't think you should put a semicolon at the end of your first SQL statement.

EDIT - for clarity I mean that this statement

  mysql_query(" INSERT INTO threads (topic ,date ,views ,user_id ,responses ,closed ,title ,close_voted ,content)
      VALUES('$threadTopic', NOW(), 0, '$selectCurrentUser', 0, 'false', '$threadTitle', 0, '$threadContent');") or die(mysql_error());

should be written as follows (with single-quotes around $selectCurrentUser replaced with parentheses):

  mysql_query(" INSERT INTO threads (topic ,date ,views ,user_id ,responses ,closed ,title ,close_voted ,content)
      VALUES('$threadTopic', NOW(), 0, ($selectCurrentUser), 0, 'false', '$threadTitle', 0, '$threadContent');") or die(mysql_error());

Additionally, the following statement

$selectCurrentUser=" SELECT user_id FROM users WHERE user_name='$userName'; ";

should have the first semicolon removed, like so:

$selectCurrentUser=" SELECT user_id FROM users WHERE user_name='$userName' ";

Answer 2

Looks from the error message that it is not taking the quotes the way you are expecting.

 'NewOrder'; ', 0, 'false', '11111111111111111111111', 0, ' 22222222222222222222' at line 2

  $userName="NewOrder";//use cookie to get name;
  $selectCurrentUser=" SELECT user_id FROM users WHERE user_name='$userName'; ";
   mysql_query(" INSERT INTO threads (topic ,date ,views ,user_id ,responses ,closed ,title ,close_voted ,content)
      VALUES('$threadTopic', NOW(), 0, '$selectCurrentUser', 0, 'false', '$threadTitle', 0, '$threadContent');") or die(mysql_error());

  mysql_close();

You only specify NewOrder as the first statement and put single quotes aruond it - I dont think you need to specify the semicolon at the end of the first SQL.

The error implies it is not seeing the code from the end quote of $userName to the 0 after $selectCurrentUser

You could add additional quotes and concatenate with . like this

  $selectCurrentUser=" SELECT user_id FROM users WHERE user_name='".$userName."'"; 

and similarly for the second statement. Hope that helps.

Answer 3

A couple of things here:

1. I don't see a field in your table structure called user_name . Is that a typo, or might you be looking for data that isn't there?

2. Secondly, you shouldn't use a delimiter in your first statement and it should be surrounded by brackets like this:

    $selectCurrentUser="(SELECT user_id FROM users WHERE user_name='$userName' LIMIT 1)"; 

3. If that still fails then I would advise retrieving user_id first (using PHP) and then explicitly passing that to the second query. I would do it like this:

    $userName="NewOrder";//use cookie to get name; $selectCurrentUser = 0; // retrieve the user_id first $result = mysql_query("SELECT user_id FROM users WHERE user_name='$userName' LIMIT 1"); while($row = mysql_fetch_assoc($result)){ // set $selectCurrentUser to the only id retrieved $selectCurrentUser = $row['user_id']; } // pass the exact user_id to the second query mysql_query(" INSERT INTO threads (topic ,date ,views ,user_id ,responses ,closed ,title ,close_voted ,content) VALUES('$threadTopic', NOW(), 0, $selectCurrentUser, 0, 'false', '$threadTitle', 0, '$threadContent')") or die(mysql_error()); mysql_close(); 

   Note: I have removed the quotes from around $selectCurrentUser in the second query.