我的插入语句怎么了？ MySQL的Java

Question

what's wrong with my insert method? my table has two columns, name, and artist..and timestamp, that too actually, how do i pass timestamp argument to the insert statement?

ok.addActionListener(new ActionListener() {
        public void actionPerformed(ActionEvent e) {
            try {
                /*FileWriter dir = new FileWriter(nameOfSong.getText()
                        + ".txt");
                BufferedWriter buffer = new BufferedWriter(dir);
                buffer.write(nameOfSong.getText());
                buffer.newLine();
                buffer.write(artist.getText());
                buffer.newLine();
                buffer.newLine();
                buffer.write(lyrics.getText());
                buffer.close();
                */

                Statement statement = connection.createStatement();
                statement.executeUpdate("INSERT INTO lyrics1_lyrics1 VALUES(" +
                nameOfSong.getText() + ", " + artist.getText() + "");


            } catch (Exception z) {
                System.err.println("Error: " + z.getMessage());
            } 
            internalFrame.dispose();
        }
    });
)

Answer 1

Always use PreparedStatement .

 String sql="INSERT INTO lyrics1_lyrics1 VALUES (?,?)";
 PreparedStatement statement = connection.prepareStatement(sql);
 statement.setString(1,nameOfSong.getText());
 statement.setString(2,artist.getText());
 statement.executeUpdate();
 statement.close();
 connection.close();

Answer 2

The text values need to be surrounded by single quotes ( '' ).

And SQL-escaped to avoid SQL injection attacks, or the first time you have a song by Little Bobby Tables , all your DB are belong to him.

Better yet, use a PreparedStatement , and let the machine do work for you.

Answer 3

You can use prepared statement for it

String query = "INSERT INTO lyrics1_lyrics1(name, artist, timestamp) values(?, ?, ?)";
PreparedStatement pstmt = conn.prepareStatement(query);
pstmt.setString(1, name); // set input parameter 2
pstmt.setString(2, artist);
pstmt.setString(3, new TimeStamp(new Date().getTime()));

You need to add an import statement for the TimeStap;

import java.sql.Timestamp;

or else use

pstmt.setString(3, new java.sql.TimeStamp(new Date().getTime()));

Example: Prepared Statement Insert .

You can find a lot of example in java2s site .

Answer 4

Change the line to:

statement.executeUpdate("INSERT INTO lyrics1_lyrics1 VALUES('" +
                    nameOfSong.getText() + "', '" + artist.getText() + "'");

Answer 5

这可能会解决您的问题：

statement.executeUpdate("INSERT INTO lyrics1_lyrics1 VALUES('" + nameOfSong.getText() + "', '" + artist.getText() + "')");`