这是一个好的python设计吗？

Question

I'm using django and i wrote this decorator to take away some of the repetitive code i found for ajax views and i want to know your opinion (too basic, bad design, try this instead, ok, etc).

def ajax_only(func):
    def _ajax_only(request,*args,**kwargs):
        if not request.is_ajax():
            return HttpResponse('<p>Ajax not supported.</p>')
        else:
            return func(request,*args,**kwargs)
    return _ajax_only

Answer 1

The only other tip I'd have here is to suggest the use of the functools.wraps decorator - it allows the decorated function to keep some attributes (such as function name), which makes it easier for debugging - the code above would be like:

from functools import wraps
def ajax_only(func):
    @wraps(func)
    def _ajax_only(request,*args,**kwargs):
        if not request.is_ajax():
            return HttpResponse('<p>Ajax not supported.</p>')
        else:
            return func(request,*args,**kwargs)
    return _ajax_only

Answer 2

是的，这看起来像是装饰器的典型有效用法。