jQuery在我的网站上不起作用

Question

I have this code: http://jsfiddle.net/AH4As/3/

It works in the fiddle, but on my site, it does not. I'm getting this error in Web Inspector

Tracking.js:4TypeError: 'undefined' is not an object (evaluating '$('a').attr('onClick').replace')

Does anybody know what wrong?

Here's my source code: http://jsfiddle.net/AH4As/24/

Answer 1

UPDATED:

$(document).ready(function(){
    $('a').attr('onClick', $('a').attr('onClick').replace("window.open('", "window.open('http://example.com/"));
});

​

http://jsfiddle.net/AH4As/10/

And here it is with an alert to show you the code has been changed: http://jsfiddle.net/AH4As/11/

Answer 2

尝试：

$('a').removeAttr('onclick').click(function(){window.open('http://example.com');return false;});

Answer 3

What about:

$(document).ready(function(){
    $('a').removeAttr('onclick');
    $('a').click(function(){
        window.open('http://www.example.com', '','location=1,menubar=1,scrollbars=1,status=1,resizable=1,width=635,height=460');
    });
});

Answer 4

You won't be able to (reliably) replace on the onclick with jQuery 1.4:

'function' === typeof $('a').attr('onclick');

And Functions don't have replace methods:

'undefined' === typeof $('a').attr('onclick').replace;

You're getting a function because jQuery is returning the property value rather than the attribute value.

The confusion from this is why jQuery added the .prop() method in 1.6 -- so it's clear that you want the attribute value, not the property value:

// with jQuery 1.6+
'string' === typeof $('a').attr('onclick');

Now, if you're not able to update jQuery currently, you can try inserting a toString before the replace :

$('a').attr('onclick').toString().replace(...)

---

On a side-note: for better coupling of the original and adjusted value, you may look at using an alternate syntax for .attr() :

$('a').attr('onclick', function (i, value) {
    return value.toString().replace('window.open(\'', 'window.open(\'http://example.com/'));
});

Answer 5

Other anchors on the page made the Query fail, in a nutshell this was my solution:

<script type="text/javascript">
$(document).ready(function(){
$('a[onclick^="window.open(\'TrackPackage.asp"]').attr('onClick', $('a[onclick^="window.open(\'TrackPackage.asp"]').attr('onClick').replace("window.open('", "window.open('http://eastcoasttvs.com/"));
});
</script>