使用指针在单个链表上工作

Question

This is a homework problem. The program was built successful, but it can't run. It just stopped. I tried to using the "struct" to make a list.I don't know what's wrong with my "insert" function. It's my first time here, hopefully I will get some advices.

//============================================================================
// Name        : test2.cpp
// Author      : yan zeng
// Version     :
// Copyright   : Your copyright notice
// Description : Hello World in C++, Ansi-style
//============================================================================


#include <iostream>
#include <stdio.h>
#include <stdlib.h>
#define TRUE 1
#define FALSE 0
typedef int BOOLEAN;
using namespace std;

struct Node {
    int value;
    struct Node *next;
};

void insert(int x, struct Node **pL);

void insert(int x, struct Node **pL){

    if (*pL == NULL) {
        struct Node **pL = (struct Node **) malloc(10 * sizeof(int *));

        (**pL).value = x;
        (*pL)->next = NULL;

    }

    else
        insert(x, &((*pL)->next));

}



int main (int argc, char **argv)
{

    // insert code here...

    //    make a list by declaring a pointer to a node

    struct Node *NodePointer = NULL;



    for (int i=3; i<20; i+=2) {
        insert(i,&NodePointer);
    }



}

Answer 1

The best advice I can give you is to learn how to use a debugger. Other advice: don't use malloc/free in C++, use new/delete .

Answer 2

There is quite a few issues in this code, the use of a debugger will definitely help here.

Your program "just stops" because it crashes at

(**pL).value = x;

I am not sure if this code was provided to you as homework to fix, or if the empty function was provided to you, and you need to fill it out. Either way, that line is wrong.

Also, as others mentioned, you are using malloc in a C++ program when you should be using new .