如何终止在C＃中的foreach循环内启动的线程

Question

I started multiple threads by for each loop in my windows service.I didn't mention any name for these threads.How can i terminate these thread. I use the following code to create threads.

 new Thread(() =>
            {
                foreach (MyClass detail in MyclassList)
                {
                    DoWork(detail);
                }

            }).Start();

By starting these threads i create a schedule task for each details.Can i dispose this thread after Scheduling is done and How?

Answer 1

Forcibly terminating threads is never a good idea. What you should really be doing is putting some suitably designed "should I continue" check inside the loop, that you can set to "no" externally. How to do that depends a bit more on context... For example:

        int shouldExit = 0;
        new Thread(() =>
        {
            foreach (MyClass detail in MyclassList)
            {
                if(Thread.VolatileRead(ref shouldExit) != 0) break;
                DoWork(detail);
            }
        }).Start();
        ...
        // to terminate loop:
        Thread.VolatileWrite(ref shouldExit, 1);

There are, however, a myriad of ways to sort out a thread-safe exit test; the only slightly tricky thing is keeping hold of some kind of context with access to the thing being checked.

Answer 2

First, I would use the Task class instead of directly creating a new thread. Then, I would use the builtin TPL cancellation mechanisms. Here is what it would look like.

var cts = new CancellationTokenSource();
var token = cts.Token;

var task = Task.Factory.StartNew(
  () =>
  {
    foreach (MyClass detail in MyclassList)
    {
      ct.ThrowIfCancellationRequested();
      DoWork(detail);
    }
  }, cts.Token); 

// Do other stuff here.

cts.Cancel(); // Request cancellation.