如何修复自动释放对象的内存泄漏

Question

I have this method which leaks ~ 6KB :

+ (EInspectorFacilityInfo*) newWithNode: (CXMLNode*) node
{
  if(node == nil) { return nil; }
  return (EInspectorFacilityInfo*)[[[EInspectorFacilityInfo alloc] initWithNode: node] autorelease];
}

here is a screenshot indicating the memory leak in instruments.

how can I get rid of this memory leak ?

Answer 1

The method has the word 'new' in it, so by the Objective-C conventions it is expected to return an owning reference to the object, ie. an object with a retain count of 1. Auto releasing the object returns an object with a retain count of 0.

You must either remove the word new from the method name, or not auto release the object - in which case, the caller will be responsible for releasing it.

Answer 2

Small addition to Jasarien answer, you should name your method something like:

+ (EInspectorFacilityInfo*) inspectorFacilityInfoWithNode: (CXMLNode*) node

This would fix your problem and match Cocoa coding style and spirit.