使用jQuery将属性从一个元素复制到另一个

Question

I have the following jQuery code which doesn't seem to be doing anything. When the link is clicked, I'm trying to get the value of its url attribute to be copied into the iframe 's src attribute.

Basically this is supposed to make links open up in an iframe (the content of the iframe is replaced every time a new link is clicked) instead of acting like normal links.

So what is wrong with my code?

$('p.tweet a').click(function(){
    var link = $(this).attr('url');
    $('iframe').attr('src',link);
})

Answer 1

maybe you may want to get the href attribute (and even prevent the default action)

$('p.tweet a').click(function(ev){
    ev.preventDefault();
    var link = this.href;  // no need to call the $ function
    $('iframe').attr('src',link);
})

Answer 2

So what is wrong with my code?

You are not canceling the default action by returning false from the click handler of the anchor you subscribed to and thus not leaving any chance for your script to execute before the browser simply redirects away from that page:

$('p.tweet a').click(function() {
    var link = $(this).attr('href');
    $('iframe').attr('src', link);
    return false;
});

And by the way notice that I've used $(this).attr('href') instead of $(this).attr('url') . The href attribute is kinda more common to anchors than the url attribute in standard HTML, but if you have invented some markup in which anchors have an url attribute then you could give it a spin.

Answer 3

The URL of a hyperlink is contained in the href attribute, not the url attribute.

You should also prevent the default action, making your code look like this:

$('p.tweet a').click(function(event){
    var link = $(this).attr('url');
    $('iframe').attr('src',link);
    // cancel default event
    event.preventDefault();
});