C＃（MVC3）存储过程LINQ SQL

Question

I have a problem that includes presenting all data from a table through a stored procedure. I'm using LINQ to access my stored procedure but the thing is that my result (data shown) is only the last row from my tables. I can't get it to work... would deeply appreciate if someone could help me / explain what im doing wrong.

Model: RecipeModel

public class RecipeModel
{
.....
        public void GetAllRecipes()
        {
            DataClassesDataContext db = new DataClassesDataContext();        

            var result = db.p_get_all_recipes();

            foreach (var r in result)
            {
                this.recipeName = r.name;
                this.recipeDescription = r.description;
                this.recipeSteps = r.steps;
                this.createdAt = r.createdAt;
                this.updatedAt = r.updatedAt;
                this.ownerID = r.owner_id;
            }

        }

Controller : RecipeController

public class RecipeController : Controller
{
        [HttpGet]
        public ActionResult Index()
        {
            RecipeModel rec = new RecipeModel();
            rec.GetAllRecipes();

            return View(rec);
}

View (Razor) : Index

@model MVC3_LINQ_SP.Models.RecipeModel
@{
    ViewBag.Title = "Index";
}

<legend>Recipe </legend>

        <p>@Html.DisplayFor(model => model.rName)</p>

Answer 1

You're not actually returning the value of your stored procedure, you're overwriting the properties of RecipeModel instead.

You should create a Recipe class to hold the return from your stored procedure:

public class Recipe
{
    public string recipeName { get; set; }
    public string recipeDescription { get; set; }
    public string recipeSteps { get; set; }
    public DateTime createdAt { get; set; }
    public DateTime updatedAt { get; set; }
    public DateTime ownerID { get; set; }
}

Then alter your procedure to fill this in - I'm assuming that db.p_get_all_recipes() is returning a queryable or list:

public IQueryable<Recipe> GetAllRecipes()
{
    DataClassesDataContext db = new DataClassesDataContext();

    return db.p_get_all_recipes().Select(r => new Recipe()
        {
        recipeName = r.name;
        recipeDescription = r.description;
        recipeSteps = r.steps;
        createdAt = r.createdAt;
        updatedAt = r.updatedAt;
        ownerID = r.owner_id;
        });

}

Then you'll need to change your view:

@model IQueryable<Recipe>

And your controller action:

[HttpGet]
        public ActionResult Index()
        {
            RecipeModel rec = new RecipeModel();    
            return View( rec.GetAllRecipes(););
        }

Answer 2

You have a problem in your model. You load all recipes from your SP and after that in cycle you are trying to set values from the result to RecipeModel fields. But in your cycle if you have more than one recipe you are doing next: in iteration 1 you get values from recipe 1 and set them to RecipeModel, after that you goind to iteration 2 and all values from recipe 2 you again set to the same object RecipeModel which already has values from recipe 1, so you just override these values.

SO you need to create a separate RecipeModel per recipe from database. Your model which you pass to view should be a list of RecipeModels and in your View you should have foreach cycle which will write recipes to html.

Answer 3

Your overwriting you local variables in the following for loop:

foreach (var r in result)
{
    this.recipeName = r.name;
    this.recipeDescription = r.description;
    this.recipeSteps = r.steps;
    this.createdAt = r.createdAt;
    this.updatedAt = r.updatedAt;
    this.ownerID = r.owner_id;
}

You need to add each iteration to a new instance of your Model and return a List or other collection type.

Answer 4

You have a RecipeModel class inside which you have a method to get all items ( A Collection of RecipeModel). Look carefully to your method. You are looping thru the collection and setting the proeperties of the Class (object of a class effectivily) again and again (Overwriting to same instance)

Ideally In the loop you need to create an instance of RecipeModel and set the values and Add that to a collection of RecipeModel.

I would not mix this method inside your Model class. I would move that to a seperate class where there will be a method to return a list of RecipeModel class. A Repositary method.