我可以在.hpp文件中包含#include吗？

Question

I have a class called A, which has its .cpp and .hpp files. It depends on classes B and C . Now, I'm wondering, should I #include B.hpp and #include C.hpp in A.cpp or A.hpp ? I think it would be beneficial for me to #include in the A.hpp file, because I'm creating a vector of B* 's, and I'm not sure that the compiler will know the correct size of B if I only forward declare it (so I couldn't pointer increment correctly)... By "forward declaration", I mean writing class B; and class C; in the beggining of A.hpp .

Answer 1

As already mentioned, you can often work-around having to #include stuff by using forward declarations, and indeed the best practice is to minimize the amount of other headers included.

But: To answer your questions headline: yes you may, and the common mechanism to avoid "circular inclusion" is the following

A.hpp:

#ifndef A_HPP_INCLUDED
#define A_HPP_INCLUDED

... // code

#endif

Now if say B.hpp includes A.hpp, and subsequently, C.hpp looks like:

#ifndef C_HPP_INCLUDED
#define C_HPP_INCLUDED

#include "A.hpp"
#include "B.hpp"

...
#endif

Then you won't get an error stating that eg 'class A' has already been defined.

Answer 2

If it's a vector of B* , you don't need to include B.hpp in the other header. A forward declaration is fine. Pointers have the same size, regardless of what they point to.

It's preferred to have includes only when necessary, and this certainly looks like it's not.

Answer 3

I don't know if i understand your class hierarchy, in my mind is like this:

B.hpp

class B
{
    B();
};

B.cpp

B::B() {};

C.hpp

class C
{
    C();
};

A.cpp

A::A() {};

A.hpp

class A
{
    A();
    B *b;
    C *C;
};

A.cpp

#include "B.hpp"
#include "C.hpp"

A::A() :
    b(NULL), c(NULL)
{
};

Is this correct? (if not, please think about provide some code ;) If your class A have pointers to class B and class C a forward declaration must be the only thing you need.

I'm not sure that the compiler will know the correct size of B if I only forward declare it

Yes, as long as you include the B.hpp and C.hpp in the A.cpp file the compiler would be able to deduce its size (the class size, the pointer size is always the same). Why? Just because in the cpp file it knows the correct size due the #include . I've found this answer that would be useful to understand what I', trying to say.

Would be fine in the hpp file instead? Maybe, if your A.hpp would not be included in other files the class B and class C does not bother and spreading into another files. So, if it is the case that would not be neccessary. But IMHO the best practice is to forward declare and #include in the cpp files when it is possible.