JavaScript，'this' 引用，当从锚标记调用对象函数时

Question

Here is a simplified version of my JS:

var myObject = function() {
    return {
        functionOne: function() {
            //some other logic here
        },
        functionTwo: function() {
            var self = this;
            //some logic here
            //then call functionOne
            self.functionOne();
        }
    };
}

Then I have this in the body of my html:

<a href="#" onclick="myObject.functionTwo()">click me</a>

Why do I get the error Uncaught TypeError: Object [some url] has no method 'functionOne' , when I click the link?

Answer 1

Your myObject is a function that needs to be called in order to get that object

<a href="#" onclick="myObject().functionTwo()">click me</a>

Why not just define myObject as an object:

var myObject = {
    functionOne: function() {
        //some other logic here
    },
    functionTwo: function() {
        var self = this;
        //some logic here
        //then call functionOne
        self.functionOne();
    }
};

Answer 2

The error that you're seeing doesn't reflect the example code you've shown.

That said, in the way that you're using the code, you should be able to reduce it to simply:

var myObject = {
    functionOne: function() {
    },
    functionTwo: function() {
        this.functionOne();
    }
}

Answer 3

What you need is for your function to be executed immediately. Further to that your declarion of the self variable leads me to think that you are trying to create a closure so that you can access functionOne from functionTwo. If that is the case then I think the following is what you were after:

var myObject = (function() {

    function func1( ) {
    }

    function func2( ) {
        func1();
    }
    return {
        functionOne: func1,
        functionTwo: func2
    };
}());