使用try语句从嵌套for循环写入文件

Question

I am seeking some way to make this nested for loop more pythonic. Specifically, how can I iterate through unique combinations of three variables, and write to file if data is present in the dictionary?

foo,bar = {},{} #filling of dicts not shown
with open(someFile,'w') as aFile:
    for year in years:
        for state in states:
            for county in counties:
                try:foo[year,state,county],bar[state,county]
                except:continue
                aFile.write("content"+"\n")

Answer 1

You could just iterate over the keys of foo and then check if bar has a corresponding key:

for year, state, county in foo:
    if (state, county) in bar:
        aFile.write(...)

This way you avoid iterating over anything that won't at least work for foo .

The disadvantage to this is that you don't know what order the keys will be iterated in. If you need them in sorted order you could do for year, state, county in sorted(foo) .

As @Blckknght pointed out in a comment, this method also will always write for every matching key. If you want to exclude some years/states/counties you could add that to the if statement (eg, if (state, county) in bar and year > 1990 to exclude years before 1990, even if they are already in the dict).

Answer 2

The suggestion of using itertools.product to generate the values you'll use as keys has already been made. I want to add some improvements in the "easier to ask for forgiveness than permission" style exception handling you're doing:

import itertools

with open(some_file, "w"):
    for year, state, county in itertools.product(years, states, counties):
        try:
            something_from_foo = foo[(year, state, county)]
            something_from_bar = bar[(state, count)]

            # include the write in the try block
            aFile.write(something_from_foo + something_from_bar)

        except KeyError: # catch only a specific exception, not all types
            pass