如何提高红宝石代码的惯用语？

Question

Since the code below looks very old fashion and ugly. But after playing around this way is only working.

def duplicated? url
  found = false
  current_user.bookmarks.each do |bookmark|
    if bookmark.url.eql? url
      found = true
    end
  end
  found
end

I eliminated the local var found and the if statement like this

def duplicated? url
  current_user.bookmarks.each do |bookmark|
    bookmark.url.eql? url
  end
end

And it returns wrong expected result.

Any idea how to improve it ? Thanks

Answer 1

I think you need Enumerable#any? here. It should be preferred to map/include pair, because it doesn't create a temp array and it returns early on first element found.

def duplicated? url
  current_user.bookmarks.any?{|b| b.url.eql? url }
end

Answer 2

def duplicated?(url)
   current_user.bookmarks.map{|bm| bm.url}.include?(url)
end