多余的Django代码

Question

I have some code that I wrote and it works perfectly fine for its purpose.

from django.shortcuts import get_object_or_404
from django.views.generic import ListView
from cab.models import Language

class LanguageDetail(ListView):


    def get_queryset(self):
        slug = self.kwargs['slug']
        language = get_object_or_404(Language, slug=slug)
        return language.snippet_set.all()

    paginate_by = 20
    template_name = 'cab/language_detail.html'

    def get_context_data(self, **kwargs):
        slug = self.kwargs['slug']
        language = get_object_or_404(Language, slug=slug)
        context = super(LanguageDetail, self).get_context_data(**kwargs)
        context['language'] = language
        return context

My problem is that I repeated two lines of code in the two functions and I don't like that.

slug = self.kwargs['slug']
language = get_object_or_404(Language, slug=slug)

how can i avoid that ?? Thanks in advance.

Answer 1

Do you mean something like this?

def get_slug(self, name):   
    slug = self.kwargs[name]
    return get_object_or_404(Language, slug=slug)

Can use as language = self.get_slug('slug')

Bear in mind that if kwargs doesn't contain name then it'll throw an error. To prevent this you could do something like:

slug = self.kwargs.get(name, None)
if slug is not None:
    ...