脚本在Powershell中运行，但在C＃中运行时出错

Question

I have a working powershell script to get the Windows product key from an machine in our network. The script runs well in powershell comand line but returns error when I try to run it from C#. I need this working to chart licenses in our corporation.

Powershell code:

function Get-WindowsKey {
$target = '$server'
$hklm = 2147483650
$regPath = "Software\Microsoft\Windows NT\CurrentVersion\DefaultProductKey"
$regValue = "DigitalProductId4"
$productKey = $null
$win32os = $null
$wmi = [WMIClass]"\\$target\root\default:stdRegProv"
$data = $wmi.GetBinaryValue($hklm,$regPath,$regValue)
$binArray = ($data.uValue)[52..66]
$charsArray = "B","C","D","F","G","H","J","K","M","P","Q","R","T","V","W","X","Y","2","3","4","6","7","8","9"
For ($i = 24; $i -ge 0; $i--) {
    $k = 0
    For ($j = 14; $j -ge 0; $j--) {
        $k = $k * 256 -bxor $binArray[$j]
        $binArray[$j] = [math]::truncate($k / 24)
        $k = $k % 24
    }
    $productKey = $charsArray[$k] + $productKey
    If (($i % 5 -eq 0) -and ($i -ne 0)) {
        $productKey = "-" + $productKey
    }
}
$productkey
}
Get-WindowsKey | Format-Table -AutoSize

Just replace $server with . or your IP

C# code that runs script:

private void RunWindowsKeyScript(string IP)
{
    try
    {
        Assembly keyAssembly = this.GetType().Assembly;
        ResourceManager keyResMan = new ResourceManager("LanMap.Resources.PS script", keyAssembly);
        string keyScript = keyResMan.GetString("WindowsKey");
        keyScript = keyScript.Replace("$server", IP);
        Runspace keyRunspace = RunspaceFactory.CreateRunspace();
        keyRunspace.Open();
        Pipeline keyPipeline = keyRunspace.CreatePipeline();
        keyPipeline.Commands.AddScript(keyScript);
        keyPipeline.Commands.Add("Out-String");
        Collection<psobject> keyResults = keyPipeline.Invoke();
        keyRunspace.Close();
        StringBuilder keyStringBuilder = new StringBuilder();
        foreach (PSObject obj in keyResults)
        {
            keyStringBuilder.AppendLine(obj.ToString());
        }
    }
    catch (Exception ex)
    {
        string s = "";
        s += " ";
    }
}

Please help if you can. I already know the error is that in C# GetBinaryValue returns null. I just can not make it work.

Answer 1

I'm not sure how you got this to work in script form with this:

$target = '$server'

Single quoted strings will not expand variables inside them. This should work just fine:

$target = "$server"

This would normally be sufficient $target = $server but since you're doing a string replace, it is best to stick with the double quotes.

Another possibility is that you're C# code is running as x86 and you're reading the WOW64 registry instead of the 64-bit registry. That might explain why you see different results between running the script and running via your C# app.

Answer 2

Update: See bottom for theory.

Testing the PowerShell code from ISE: looks like GetBinaryValue is failing:

$target = 'localhost'
$hklm = 2147483650
$regPath = "Software\Microsoft\Windows NT\CurrentVersion\DefaultProductKey"
$regValue = "DigitalProductId4"
$productKey = $null
$win32os = $null
$wmi = [WMIClass]"\\$target\root\default:stdRegProv"
$data = $wmi.GetBinaryValue($hklm,$regPath,$regValue)

if ($data -eq $null) { Write-DEbug "Data is NULL"; return "STOP 2" }

write-debug '$Data'
write-debug ("$($data): " + ($data | gm | out-string))
write-debug ("$($data): " + ($data | fl * | out-string))

if ($data.uValue -eq $null) { Write-Debug "Data.uValue is NULL"; return "STOP 3" }
# rest cut for testing

results in:

DEBUG: $Data
DEBUG: System.Management.ManagementBaseObject: 

   TypeName: System.Management.ManagementBaseObject#\__PARAMETERS

Name             MemberType    Definition                      
----             ----------    ----------                      
PSComputerName   AliasProperty PSComputerName = __SERVER       
ReturnValue      Property      uint32 ReturnValue {get;set;}   
uValue           Property      byte[] uValue {get;set;}        
__CLASS          Property      string __CLASS {get;set;}       
__DERIVATION     Property      string[] __DERIVATION {get;set;}
__DYNASTY        Property      string __DYNASTY {get;set;}     
__GENUS          Property      int __GENUS {get;set;}          
__NAMESPACE      Property      string __NAMESPACE {get;set;}   
__PATH           Property      string __PATH {get;set;}        
__PROPERTY_COUNT Property      int __PROPERTY_COUNT {get;set;} 
__RELPATH        Property      string __RELPATH {get;set;}     
__SERVER         Property      string __SERVER {get;set;}      
__SUPERCLASS     Property      string __SUPERCLASS {get;set;}  



DEBUG: System.Management.ManagementBaseObject: 

PSComputerName   : 
__GENUS          : 2
__CLASS          : __PARAMETERS
__SUPERCLASS     : 
__DYNASTY        : __PARAMETERS
__RELPATH        : 
__PROPERTY_COUNT : 2
__DERIVATION     : {}
__SERVER         : 
__NAMESPACE      : 
__PATH           : 
ReturnValue      : 2
uValue           : 
Properties       : {ReturnValue, uValue}
SystemProperties : {__GENUS, __CLASS, __SUPERCLASS, __DYNASTY...}
Qualifiers       : {}
ClassPath        : __PARAMETERS
Site             : 
Container        : 




DEBUG: Data.uValue is NULL
STOP 3

That ReturnValue: 2 corresponds to ERROR_FILE_NOT_FOUND (assuming the ReturnValue member is reflecting the return value of GetBinaryValue where 0 is success, otherwise standard Windows API error returns).

Update:

Under by ISE instance even get this:

PS [32] C:\ #50> gp "HKLM:\SOFTWARE\Microsoft\Windows NT\CurrentVersion\DefaultProductKey"
gp : Cannot find path 'HKLM:\SOFTWARE\Microsoft\Windows NT\CurrentVersion\DefaultProductKey' because it does not exist.
At line:1 char:1
+ gp "HKLM:\SOFTWARE\Microsoft\Windows NT\CurrentVersion\DefaultProductKey"
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (HKLM:\SOFTWARE\...faultProductKey:String) [Get-ItemProperty], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetItemPropertyCommand

But I can see the key... however a 64 bit instance of ISE and it works.

The key is only available (directly) to 64bit processes, the default in recent Visual Studio versions is for most applications to be built as 32bit (most applications don't need the extra address space), a 32bit .NET application will load the 32bit PowerShell runtime assemblies.

Have you tried building your application for 64bit?

PS. This question might help: Reading 64bit Registry from a 32bit application