[英]Nested ForEach loop to Linq
I am trying to convert below nested for each loop into Linq. 我试图将下面的每个循环嵌套转换为Linq。 However I am still unable to do it successfully.
但是我仍然无法成功完成。
var objAct = new List<InformaticsBenchmarkSummary>();
foreach (var item in op)
{
foreach (var lstTp5 in lstTopFive)
{
if (item.UnitOfOperations.ContainsKey(lstTp5.SystemID))
{
var objIbm = new InformaticsBenchmarkSummary();
objIbm.CompanyId = item.CompanyId;
objIbm.CompanyName = item.CompanyName;
objIbm.LocationId = item.LocationId;
objIbm.LocationName = item.LocationName;
objIbm.UnitOfOperations.Add(lstTp5.SystemID,
item.UnitOfOperations[lstTp5.SystemID]);
objAct.Add(objIbm);
}
}
}
Where UnitOfOperations
is of type Dictionary<int,string>()
; UnitOfOperations
的类型为Dictionary<int,string>()
;
op
is again List<InformaticsBenchmarkSummary>()
op
再次List<InformaticsBenchmarkSummary>()
lstTopFive
is List<int>()
lstTopFive
是List<int>()
I tried, something like this but was unsuccessful syntactically 我尝试过这样的事情,但语法不成功
var output = from item in op
from lstTp5 in lstTopFive
where item.UnitOfOperations.ContainsKey(lstTp5.SystemID)
let v = new InformaticsBenchmarkSummary()
{
CompanyId = item.CompanyId,
CompanyName = item.CompanyName,
LocationId = item.LocationId,
LocationName = item.LocationName
}
.UnitOfOperations.Add(lstTp5.SystemID, item.UnitOfOperations[lstTp5.SystemID])
select v;
Nested loop works perfectly but I think, linq on this will increase performance. 嵌套循环工作得很好,但我认为,linq就可以提高性能。 Appreciate any help.
感谢任何帮助。
It is impossible in a Linq query-syntax to use the UnitOfOperations.Add
in the select. Linq查询语法中不可能在
UnitOfOperations.Add
中使用UnitOfOperations.Add
。 But you can do it using Method Chain and a SelectMany
method: 但是你可以使用Method Chain和
SelectMany
方法来完成它:
var objAcu = (op.SelectMany(item => lstTopFive, (item, lstTp5) => new { item, lstTp5 }) // <- Bad readability
.Where(t => t.item.UnitOfOperations.ContainsKey(t.lstTp5.SystemID))
.Select(t =>
{
var objIbm = new InformaticsBenchmarkSummary
{
CompanyId = t.item.CompanyId,
CompanyName = t.item.CompanyName,
LocationId = t.item.LocationId,
LocationName = t.item.LocationName
};
objIbm.UnitOfOperations.Add(t.lstTp5.SystemID, t.item.UnitOfOperations[t.lstTp5.SystemID]);
return objIbm;
})).ToList();
If the property UnitOfOperations
has a public set
, in this case, you can use the query-syntax. 如果属性
UnitOfOperations
具有公共set
,则在这种情况下,您可以使用query-syntax。
How do you replace 1 foreach
? 你如何取代1
foreach
? By a from ... in ...
from ... in ...
Then, to replace 2 foreach
, use 2 from ... in ...
然后,要替换2个
foreach
,请使用2 from ... in ...
var objAct = (from item in op // First foreach loop
from lstTp5 in lstTopFive // Second foreach loop
where item.UnitOfOperations.ContainsKey(lstTp5.SystemID)
select new InformaticsBenchmarkSummary
{
CompanyId = item.CompanyId,
CompanyName = item.CompanyName,
LocationId = item.LocationId,
LocationName = item.LocationName,
UnitOfOperations = { { lstTp5.SystemID, item.UnitOfOperations[lstTp5.SystemID] } }
}).ToList();
But I doubt it will increase performance in such an operation. 但我怀疑它会提高这种操作的性能。
Anyway, I don't understand what you try to achieve. 无论如何,我不明白你想要达到的目标。 Because in all items of the output will have one and only one element in the dictionary
UnitOfOperations
. 因为在输出的所有项目中将在字典
UnitOfOperations
只有一个且只有一个元素。 Is it really what you want to do? 这真的是你想要做的吗?
List<int> systemIdTop5 = lstTopFive.Select(tp5 => tp5.SystemID).ToList();
var objAct = (from item in op
select new InformaticsBenchmarkSummary
{
CompanyId = item.CompanyId,
CompanyName = item.CompanyName,
LocationId = item.LocationId,
LocationName = item.LocationName,
UnitOfOperations = systemIdTop5.Intersect(item.UnitOfOperations.Keys)
.ToDictionary(systemId => systemId, systemId => item.UnitOfOperations[systemId])
}).ToList();
You're close, but you can't just use a void
returning method in LINQ query like that. 你很接近,但你不能在LINQ查询中使用
void
返回方法。 (And if it wasn't void
-returning, then v
would be the result of Add()
, which would be most likely wrong.) (如果它不是
void
返回,则v
将是Add()
的结果,这很可能是错误的。)
If you wanted to create a new Dictionary
for UnitOfOperations
, you could set it the same way as other properties. 如果要为
UnitOfOperations
创建新的Dictionary
,可以将其设置为与其他属性相同的方式。 But if you can't do that (probably because UnitOfOperations
has a private setter) or you don't want to (because UnitOfOperations
is initialized to some value that you want to keep), you can use a lesser known feature of C#: collection initializer inside object initializer: 但是如果你不能这样做(可能是因为
UnitOfOperations
有一个私有的setter)或你不想(因为UnitOfOperations
被初始化为你想保留的某个值),你可以使用一个鲜为人知的C#特性:集合对象初始化器内的初始化器:
UnitOfOperations = { { lstTp5.SystemID, item.UnitOfOperations[lstTp5.SystemID] } }
The effect of this code is the same as if you wrote: 此代码的效果与您编写的相同:
createdObject.UnitOfOperations.Add(lstTp5.SystemID, item.UnitOfOperations[lstTp5.SystemID]);
The only difference is that it's not a statement, it's part of an expression, which means you can use it in a LINQ query. 唯一的区别是它不是一个语句,它是表达式的一部分,这意味着你可以在LINQ查询中使用它。
The whole query would then be: 整个查询将是:
var output = from item in op
from lstTp5 in lstTopFive
where item.UnitOfOperations.ContainsKey(lstTp5.SystemID)
select new InformaticsBenchmarkSummary()
{
CompanyId = item.CompanyId,
CompanyName = item.CompanyName,
LocationId = item.LocationId,
LocationName = item.LocationName,
UnitOfOperations =
{
{ lstTp5.SystemID, item.UnitOfOperations[lstTp5.SystemID] }
}
};
As far as I can tell it is your UnitOfOperations that you're having difficulty with. 据我所知,你的UnitOfOperations是你遇到的困难。 If it is initialized in the constructor you can use this:
如果它在构造函数中初始化,您可以使用:
var output = from item in op
from lstTp5 in lstTopFive
where item.UnitOfOperations.ContainsKey(lstTp5.SystemID)
select
new InformaticsBenchmarkSummary()
{
CompanyId = item.CompanyId,
CompanyName = item.CompanyName,
LocationId = item.LocationId,
LocationName = item.LocationName,
UnitOfOperations = { { lstTp5.SystemID, item.UnitOfOperations[lstTp5.SystemID] } }
};
The result is an IEnumerable
, if you want it as a list, call output.ToList()
. 结果是一个
IEnumerable
,如果你想将它作为一个列表,则调用output.ToList()
。
Two side notes: 两个旁注:
UnitOfOperations
), but I guess that is desired. UnitOfOperations
),但我想这是期望的。 In the worst case scenario all items in op
have a UnitOfOperations
that contain all the SystemID
in lstTopFive
giving us a total of op.Count()*lstTopFive.Count()
items in the output
. op
有UnitOfOperations
包含所有SystemID
在lstTopFive
给我们一个总的op.Count()*lstTopFive.Count()
中的项目output
。 May this help U : 愿这有助于你:
var output = from item in op
join lstTp5 in lstTopFive on item.UnitOfOperations.Key equals lstTp5.SystemID
select new InformaticsBenchmarkSummary
{
CompanyId = item.CompanyId,
CompanyName = item.CompanyName,
LocationId = item.LocationId,
LocationName = item.LocationName,
UnitOfOperations = item.UnitOfOperations
};
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.