[英]Best Practice for Repeating SQL Statements
我正在寻找一种更好的方法来编写高度重复的sql语句。 我知道我可以通过例如使用PHP方法来做到这一点,但是我想要一个纯SQL解决方案。 我正在使用Sybase。
select
"SvHKeyId"=sh.KeyId,
"Scale"="Partial PTSD",
"ScoreText"=convert(varchar(3),
(case
when
(case
when
1 in (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum between 1 and 13)
and 1 in (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum between 15 and 21)
and 1 in (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum between 22 and 26)
then 'Yes'
else 'No'
end)
= 'Yes'
and
(case
when
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=30) >= 2
or (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=32) >= 2
or (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=33) >= 2
or (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=29) >= 2
or (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=45) >= 2
then 1
else 0
end)
+
(case
when
(case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=36) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=44) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=42) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=34) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=35) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46) >= 2 then 1 else 0 end)
>= 3 then 1
else 0
end)
+
(case
when
(case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=40) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=43) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=28) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=39) >= 2 then 1 else 0 end)
>= 2 then 1
else 0
end)
>=2
then 'Yes'
else 'No'
end)
= 'Yes'
then 'Yes'
else 'No'
end)
),
"ScoreNum"=
(case
when
(case
when
1 in (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum between 1 and 13)
and 1 in (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum between 15 and 21)
and 1 in (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum between 22 and 26)
then 'Yes'
else 'No'
end)
= 'Yes'
and
(case
when
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=30) >= 2
or (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=32) >= 2
or (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=33) >= 2
or (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=29) >= 2
or (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=45) >= 2
then 1
else 0
end)
+
(case
when
(case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=36) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=44) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=42) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=34) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=35) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46) >= 2 then 1 else 0 end)
>= 3 then 1
else 0
end)
+
(case
when
(case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=40) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=43) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=28) >= 2 then 1 else 0 end)
+ (case when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=39) >= 2 then 1 else 0 end)
>= 2 then 1
else 0
end)
>=2
then 'Yes'
else 'No'
end)
= 'Yes'
then 1
else 0
end)
from
SurvHeader sh
where
sh.KeyId=105101
这是一个计分程序。 我正在比较一系列子得分,以得出总体得分。 有更好的SQL方法吗? 我想我可以使用存储过程吗?
这是一个更极端的示例,其中我使用了太多子查询,但超出了限制:
select
"SvHKeyId"=sh.KeyId,
"Scale"="Total",
"ScoreText"=convert(varchar(3),
(select sum(Resp) from SurvResp sr where sh.KeyId=sr.SvHKeyId
and QuestNum in (28,29,30,31,32,33,34,35,36,39,40,42,43,44,45,46) and Resp <> 5)
+
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37) <> 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38) <> 5
then
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37)
> (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37)
< (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37)
= (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
end)
else
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37) = 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38) = 5
then 0
else
(case
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37)
else 0
end)
end)
end)
+
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31) <> 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47) <> 5
then
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31)
> (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31)
< (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31)
= (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
end)
else
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31) = 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47) = 5
then 0
else
(case
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31)
else 0
end)
end)
end)
+
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46) <> 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48) <> 5
then
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46)
> (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46)
< (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46)
= (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
end)
else
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46) = 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48) = 5
then 0
else
(case
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46)
else 0
end)
end)
end)
),
"ScoreNum"=
(select sum(Resp) from SurvResp sr where sh.KeyId=sr.SvHKeyId
and QuestNum in (28,29,30,31,32,33,34,35,36,39,40,42,43,44,45,46) and Resp <> 5)
+
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37) <> 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38) <> 5
then
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37)
> (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37)
< (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37)
= (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
end)
else
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37) = 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38) = 5
then 0
else
(case
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38)
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=38) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=37)
else 0
end)
end)
end)
+
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31) <> 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47) <> 5
then
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31)
> (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31)
< (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31)
= (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
end)
else
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31) = 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47) = 5
then 0
else
(case
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47)
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=47) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=31)
else 0
end)
end)
end)
+
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46) <> 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48) <> 5
then
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46)
> (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46)
< (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46)
= (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
then
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
end)
else
(case
when
(select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46) = 5
and (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48) = 5
then 0
else
(case
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48)
when (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=48) = 5
then (select Resp from SurvResp sr where sh.KeyId=sr.SvHKeyId and sr.QuestNum=46)
else 0
end)
end)
end)
from
SurvHeader sh
where sh.KeyId=105101
这些文字中的大多数应该是数据,而不是代码。 我强烈建议将这些巨大的开关重构为数据,以便更简单的查询可以对其进行评估。 这样,“纯SQL”解决方案将更加可行,并且从长远来看,性能和维护都将更好。 也许您可以加入和比较的Scoring
表?
Scoring (Question, Answer, Result)
是一种概念上的可能性,希望不要过于简化。
如前所述, “您可以使用任何语言编写FORTRAN。”
看来,即使是T-SQL。
UPDATE
如果这些计算已经完成,并且您已在当前事务中更新了表,则无需仅仅因为尚未提交就重新执行它们。 如果该事务中的任何查询在事务中较早时已更新,则将获取该事务的更新数据。
有关Sybase ASE事务的更多信息。
另外,您不应该期望GO
在存储过程中工作 。 它在IDE中用作批处理分隔符,而不是事务控制。
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.