[英]user defined illegal exception
我有这个程序,如果任意两个边的总和大于1,则应该返回非法三角形异常。 我应该放在哪里
if(side1 + side2 < side3)
throw new illegalTriangleException("Sum of any 2 sides not bigger than the other side");
if(side1 + side3 < side2)
throw new illegalTriangleException("Sum of any 2 sides not bigger than the other side");
if(side3 + side2 < side1)
throw new illegalTriangleException("Sum of any 2 sides not bigger than the other side");
在这里? 我不确定放在哪里。 我也想知道我编写代码的方式是否正确?
class Triangle
{
public double side1, side2, side3;
public Triangle() { }
public Triangle(double s1, double s2, double s3)
{
side1 = s1;
side2 = s2;
side3 = s3;
}
public double Side1
{
get { return side1; }
set {
if (value<0)
side1 = value;
}
}
public double Side2
{
get { return side2; }
set {
if (value < 0)
side2 = value;
}
}
public double Side3
{
get { return side3; }
set
{
if (value < 0)
side3 = value;
}
}
}
class IllegalTriangleException : Exception
{
public IllegalTriangleException() : base ("Sum of any 2 sides is not greater than the other") { }
public IllegalTriangleException(string msg) : base("Sum of any 2 sides is not greater than the other" + msg) { }
public IllegalTriangleException(string msg, Exception innerException) : base("Sum of any 2 sides is not greater than the other" + msg, innerException){ }
}
class Program
{
static void Main(string[] args)
{
try
{
Console.WriteLine("Length of side: ");
double side1 = Convert.ToDouble(Console.ReadLine());
double side2 = Convert.ToDouble(Console.ReadLine());
double side3 = Convert.ToDouble(Console.ReadLine());
Console.WriteLine("Your triangle is puuuuurfect");
}
catch (IllegalTriangleException ex)
{
Console.WriteLine(ex.Message);
}
}
}
Zohar的答案是具有不变性的可变三角形的良好实现。
但是,这里有一个关于不变性的很好的论点(即没有设置器),否则您将面临通过无效状态在有效状态之间转换的问题:
Triangle a(3, 4, 5);
Triangle b(30, 40, 50);
// let's adjust triangle a to match b
try {
a.Side1 = b.Side1; // nope
a.Side2 = b.Side2;
a.Side3 = b.Side3;
}
catch(IllegalTriangleException e) {
// darn, we accidentally went through an invalid state of (30, 4, 5)
}
不变版本更易于实现
class ImmutableTriangle
{
public ImmutableTriangle(double side1, double side2, double side3)
{
if(side1 + side2 <= side3 ||
side2 + side3 <= side1 ||
side3 + side1 <= side2)
throw new IllegalTriangleException("Sum of any 2 sides not bigger than the other side");
}
if(side1 <= 0 || side2 <= 0 || side3 <= 0)
throw new IllegalTriangleException("Sides must be positive");
}
Side1 = side1;
Side2 = side2;
Side3 = side3;
}
public double Side1 { get; private set; }
public double Side2 { get; private set; }
public double Side3 { get; private set; }
}
(请注意,我还用<
替换了<=
,并修复了负数长度检查)
这是我会做的:
通过将字段设为私有,可以确保仅通过使用适当的属性来为其分配任何值。
请注意,构造函数将第一个和第二个值分配给字段,将第三个值分配给属性以检查非法三角形。
public class Triangle
{
private double _side1, _side2, _side3;
public Triangle() { }
public Triangle(double side1, double side2, double side3)
{
_side1 = side1;
_side2 = side2;
Side3 = side3; // Note: this is calling the property
}
public double Side1
{
get { return _side1; }
set {
if (value > 0)
{
CheckForIllegalTriangle(value, Side2, Side3);
_side1 = value;
}
}
}
public double Side2
{
get { return _side2; }
set {
if (value > 0)
{
CheckForIllegalTriangle(Side1, value, Side3);
_side2 = value;
}
}
}
public double Side3
{
get { return _side3; }
set
{
if (value > 0)
{
CheckForIllegalTriangle(Side1, Side2, value);
_side3 = value;
}
}
}
private void CheckForIllegalTriangle(double side1, double side2, double side3) {
if((side1 + side2 < side3) ||
(side1 + side3 < side2) ||
(side3 + side2 < side1))
{
throw new illegalTriangleException("Sum of any 2 sides not bigger than the other side");
}
}
}
首先。
class Triangle
{
private double side1, side2, side3;
private Triangle() { }
public Triangle(double s1, double s2, double s3)
{
side1 = s1;
side2 = s2;
side3 = s3;
CheckForIllegalTriangle();
}
public double Side1
{
get { return side1; }
set
{
if (value < 0)
side1 = value;
}
}
public double Side2
{
get { return side2; }
set
{
if (value < 0)
side2 = value;
}
}
public double Side3
{
get { return side3; }
set
{
if (value < 0)
side3 = value;
}
}
public void CheckForIllegalTriangle()
{
if ((side1 + side2 < side3) ||
(side1 + side3 < side2) ||
(side3 + side2 < side1))
throw new IllegalTriangleException("Sum of any 2 sides not bigger than the other side");
}
}
class IllegalTriangleException : Exception
{
public IllegalTriangleException() : base("Sum of any 2 sides is not greater than the other") { }
public IllegalTriangleException(string msg) : base("Sum of any 2 sides is not greater than the other" + msg) { }
public IllegalTriangleException(string msg, Exception innerException) : base("Sum of any 2 sides is not greater than the other" + msg, innerException) { }
}
class Program
{
static void Main(string[] args)
{
try
{
Console.WriteLine("Length of side 1: ");
double side1 = Convert.ToDouble(Console.ReadLine());
Console.WriteLine("Length of side 2: ");
double side2 = Convert.ToDouble(Console.ReadLine());
Console.WriteLine("Length of side 3: ");
double side3 = Convert.ToDouble(Console.ReadLine());
Triangle t1 = new Triangle(side1, side2, side3);
Console.WriteLine("Your triangle is puuuuurfect");
}
catch (IllegalTriangleException ex)
{
Console.WriteLine(ex.Message);
}
}
}
每一方都不可能大于另一方,所以我认为您的问题是错误的。 但是,这就是我想您要实现的目标。
class Triangle
{
public double side1, side2, side3;
public Triangle() { }
public Triangle(double s1, double s2, double s3)
{
side1 = s1;
side2 = s2;
side3 = s3;
if(side1 + side2 < side3)
throw new illegalTriangleException("Sum of any 2 sides not bigger than the other side");
if(side1 + side3 < side2)
throw new illegalTriangleException("Sum of any 2 sides not bigger than the other side");
if(side3 + side2 < side1)
throw new illegalTriangleException("Sum of any 2 sides not bigger than the other side");
}
public double Side1
{
get { return side1; }
set {
if (value>0)
side1 = value;
}
}
public double Side2
{
get { return side2; }
set {
if (value > 0)
side2 = value;
}
}
public double Side3
{
get { return side3; }
set
{
if (value > 0)
side3 = value;
}
}
}
class IllegalTriangleException : Exception
{
public IllegalTriangleException(string msg) : base(msg) { }
}
class Program
{
static void Main(string[] args)
{
try
{
Console.WriteLine("Length of side: ");
double side1 = Convert.ToDouble(Console.ReadLine());
double side2 = Convert.ToDouble(Console.ReadLine());
double side3 = Convert.ToDouble(Console.ReadLine());
Triangle t = new Triangle(side1, side2, side3);
Console.WriteLine("Your triangle is puuuuurfect");
}
catch (IllegalTriangleException ex)
{
Console.WriteLine(ex.Message);
}
}
}
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.