繁体   English   中英

错误:ORA-00900 SQLStatement无效,但语句仍按预期运行

[英]Error: ORA-00900 Invalid SQLStatement but statement still works as intended

我创建了一个可以更改和从数据库检索数据的GUI。 但是,即使任务已完成,某些按钮也会引发SQLException。 (例如,它会给我一个错误,但仍然可以正确地插入数据库中。

这是我的代码:

String sqlUser = e.getActionCommand();
String sql;
PreparedStatement stmt;
try{
    if(sqlUser.equals("Save Record"))
                {
                    ResultSet rs;
                    sql = "INSERT INTO table_name (name, ID, result, date, date2) values (?,?,?,?,?)";
                    stmt = con.prepareStatement(sql);
                    stmt.setString(1, textField.getText());
                    stmt.setInt(2, Integer.parseInt(textField_1.getText()));
                    stmt.setString(3, textField_2.getText());
                    stmt.setDate(4, new java.sql.Date(System.currentTimeMillis()));
                    stmt.setDate(5, new java.sql.Date(System.currentTimeMillis()));
                    rs = stmt.executeQuery();
                    updateUI(rs);
                    con.commit();
                }
    else if(sqlUser.equals("Save Update"))
                {
                    ResultSet rs;
                    sql = "UPDATE table_name SET result = ? , date = ?, date2 = ? WHERE name = ? AND ID = ?";
                    stmt = con.prepareStatement(sql);
                    stmt.setString(4, textField.getText());
                    stmt.setInt(5, Integer.parseInt(textField_1.getText()));
                    stmt.setString(1, textField_2.getText());
                    stmt.setDate(2, new java.sql.Date(System.currentTimeMillis()));
                    stmt.setDate(3, new java.sql.Date(System.currentTimeMillis()));
                    rs = stmt.executeQuery();
                    updateUI(rs);
                    con.commit();
                }
} catch (SQLException err)
{
    JOptionPane.showMessageDialog(null,err.getMessage());
}

updateUI方法如下:

public void updateUI(ResultSet rs)
    {
        try
        {
            String strCDate = dateFormat.format(rs.getDate("date"));
            String strLADate = dateFormat.format(rs.getDate("date2"));

            textField.setText(rs.getString("name"));
            textField_1.setText(Integer.toString(rs.getInt("ID")));
            textField_2.setText(rs.getString("result"));
            lblCalculationDate.setText("Date: " + strCDate);
            lblLastAccessDate.setText("Date2: " + strLADate);
        }
        catch(SQLException err)
        {
            JOptionPane.showMessageDialog(null,err.getMessage());
        }
    }

DateFormat是这样的(不要认为它太重要了):

private DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd");
  • 删除con.commit(); 因为默认情况下数据库连接是自动提交的。
  • 仅当设置con.setAutoCommit(false);时,才可以使用commit() con.setAutoCommit(false);
  • 插入执行不返回resultSet,因此删除rs = stmt.executeQuery(); 而是更改updateUI方法以接受两个日期作为参数

完整的新代码:

    String sqlUser = e.getActionCommand();
    String sql;
    PreparedStatement stmt;
    try{
        int id = Integer.parseInt(textField_1.getText());
        java.sql.Date date = new java.sql.Date(System.currentTimeMillis());
                        java.sql.Date date2 = new java.sql.Date(System.currentTimeMillis());
        if(sqlUser.equals("Save Record"))
                    {
                        ResultSet rs;

                        sql = "INSERT INTO table_name (name, ID, result, date, date2) values (?,?,?,?,?)";
                        stmt = con.prepareStatement(sql);
                        stmt.setString(1, textField.getText());
                        stmt.setInt(2, id);
                        stmt.setString(3, textField_2.getText());
                        stmt.setDate(4,date );
                        stmt.setDate(5,date2);
                        // OLD: rs = stmt.executeQuery();
                        // OLD: updateUI(rs);
                        stmt.executeUpdate();
                        updateUI(id,  textField.getText(),textField_2.getText(),date,date2 );
                        // OLD: con.commit();
                    }
        else if(sqlUser.equals("Save Update"))
                    {
                        ResultSet rs;
                        sql = "UPDATE table_name SET result = ? , date = ?, date2 = ? WHERE name = ? AND ID = ?";
                        stmt = con.prepareStatement(sql);
                        stmt.setString(4, textField.getText());
                        stmt.setInt(5, id);
                        stmt.setString(1, textField_2.getText());
                        stmt.setDate(2, date);
                        stmt.setDate(3, date2);
                        // OLD: rs = stmt.executeQuery();
                        // OLD: updateUI(rs);
                        stmt.executeUpdate();
                        updateUI(id,  textField.getText(),textField_2.getText(),date,date2 );
                        // OLD: con.commit();
                    }
    } catch (SQLException err)
    {
        JOptionPane.showMessageDialog(null,err.getMessage());
    }

The updateUI method is as follows:

    public void updateUI(int id, String name, String result, Date date, Date date2)
        {
            try
            {
                String strCDate = dateFormat.format(date);//rs.getDate("date"));
                String strLADate = dateFormat.format(date2);//rs.getDate("date2"));

                textField.setText(name);//rs.getString("name"));
                textField_1.setText(id+"");//Integer.toString(rs.getInt("ID")));
                textField_2.setText(result);//rs.getString("result"));
                lblCalculationDate.setText("Date: " + strCDate);
                lblLastAccessDate.setText("Date2: " + strLADate);
            }
            catch(SQLException err)
            {
                JOptionPane.showMessageDialog(null,err.getMessage());
            }
        }

对于插入和更新,您应该使用

stmt.execute(); rs = stmt.getResultSet();

要么

stmt.executeUpdate(); rs = stmt.getResultSet();

另外,由于您没有设置con.setAutoCommit(false)因此不需要con.commit()

不相关的旁注:作为最佳实践,您应该避免在Java代码中对SQL进行硬编码

暂无
暂无

声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM