[英]array allocated by malloc gets lost
我正在尝试实现神经网络,但是初始化不起作用,但是我无法发现我的错误:
typedef struct{
int numWeights;
double* weights;
double wBias;
}NeuronTanh;
typedef struct{
int numNeurons;
NeuronTanh* neurons;
}Layer;
typedef struct{
int numLayers;
Layer* layers;
}Network;
//--------------------------------
void initializeNetwork(Network* network){
//malloc stuff
network->numLayers = NUMBER_LAYERS;
network->layers = malloc(NUMBER_LAYERS * sizeof(Layer));
network->layers[0].numNeurons = 1
network->layers[1].numNeurons = 4
network->layers[2].numNeurons = 2
for(int currentLayerIndex=0; currentLayerIndex<network->numLayers;++currentLayerIndex){
Layer l = network->layers[currentLayerIndex];
l.neurons = malloc(l.numNeurons * sizeof(NeuronTanh));
for(int j=0; j<l.numNeurons; ++j){
if(currentLayerIndex==0){
l.neurons[j].numWeights = 2;
}else{
l.neurons[j].numWeights = network->layers[currentLayerIndex-1].numNeurons;
}
l.neurons[j].weights = malloc((1+l.neurons[j].numWeights) * sizeof(double));
randomizeNeuron(&(l.neurons[j]));
}
}
printNetwork(*network);
}
现在我的问题恰恰是,在最里面的for循环中,我可以在randomizeNeuron(...)之后打印所有权重,但是如果我想在函数末尾打印所有权重或神经元,则神经元数组为NULL,而各层数组初始化良好。 为什么神经元(和权重)数组为NULL?
编辑
printNetwork(Network network){
fprintf(stderr, "Layers:%i\n",network.numLayers);
for(int numLayer = 0; numLayer<network.numLayers; ++numLayer){
fprintf(stderr, "Layer %i -------------------\n",numLayer);
for(int numNeuron=0; numNeuron<network.layers[numLayer].numNeurons; ++numNeuron){
fprintf(stderr, "Neuron %i: ", numNeuron);
fprintf(stderr, "number of neurons: %i: ", network.layers[numLayer].numNeurons);
if(network.layers[numLayer].neurons != NULL){
for(int numWeight=0; numWeight<network.layers[numLayer].neurons[numNeuron].numWeights; ++numWeight){
fprintf(stderr, "%f ",network.layers[numLayer].neurons[numNeuron].weights[numWeight]);
}
fprintf(stderr, "%f\n", network.layers[numLayer].neurons[numNeuron].wBias);
}
}
}
}
输出是
Layers:3
Layer 0 -------------------
Neuron 0: number of weights: 2: Neuron 1: number of weights: 2: Layer 1 -------------------
Neuron 0: number of weights: 4: Neuron 1: number of weights: 4: Neuron 2: number of weights: 4: Neuron 3: number of weights: 4: Layer 2 -------------------
Neuron 0: number of weights: 1:
问题出在这两行:
Layer l = network->layers[currentLayerIndex];
l.neurons = malloc(l.numNeurons * sizeof(NeuronTanh));
malloc行不影响network->layers[currentLayerIndex].neurons
。
假设network->layers[currentLayerIndex].neurons
地址为X。 后
Layer l = network->layers[currentLayerIndex];
l.neurons
具有地址X,因为它是从network->layers[currentLayerIndex].neurons
。
现在, malloc
返回地址Y ,该地址分配给l.neurons
而network->layers[currentLayerIndex].neurons
保持X。
因此network->layers[currentLayerIndex]
不受其他初始化函数的影响。 所有这些初始化都在l
上执行。
编辑:
可能的解决办法是分配l.neurons
回network->layers[currentLayerIndex].neurons
的inialization完成后。
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.