繁体   English   中英

如何避免在Java中半重复方法组?

[英]How can I avoid semi-repeating groups of methods in java?

假设我写了以下方法:

public void submitForm1() {
        open();
        setField(1, "blah");
        setField(3, "bla");
        setField(4, "blah blah");
        submit();
    }

public void submitForm2() {
        open();
        setField(1, "blah");
        checkBox(1 , true);
        submit();
}

....

public void submitForm100() {
        open();
        setField(1, "bla");
        setField(2, "bla bla");
        setField(3, "blah");
        setArea(1, "blah blah");
        submit();
}

这些方法使我感到自己在不断重复自己。 我觉得应该这样写:

public void submitForm1() {
        MyMethods.submitForm(
            {SET_FIELD, 1, "blah"},
            {SET_FIELD, 3, "bla"},
            {SET_FIELD, 4, "blah blah"}
        );
    }

public void submitForm2() {
        MyMethods.submitForm(
            {SET_FIELD, 1, "blah"},
            {CHECKBOX, 1, true}
        );
}

....

public void submitForm100() {
        MyMethods.submitForm(
            {SET_FIELD, 1, "bla"},
            {SET_FIELD, 2, "bla bla"},
            {SET_FIELD, 3, "blah"},
            {SET_AREA, 1, "blah blah"},
        );
}

这样,我将不必一遍又一遍地重复所有这些打开和提交方法。

有没有办法做到这一点?

例如,您可以使用“回调” 为此,请执行以下操作:

void doInSubmit(SubmitCallback callback)
{
    open();
    callback.call();
    submit();
}

外面:

public void submitForm100() 
{
    doInSubmit(new SubmitCallback() 
    {
        void call()
        {
            setField(1, "bla");
            setField(2, "bla bla");
            setField(3, "blah");
            setArea(1, "blah blah");
        }
    })        
}

您可以使用类似:

public interface FormSubmission {
  void set();
  default submitForm() {
    open();
    set();
    submit();
  }
}

然后,您的代码将如下所示:

Map<Integer, FormSubmission > forms = new HashMap<> ();

//in constructor or static initialisation block:
forms.put(1, () -> { setField(1, "blah");
                     setField(3, "bla");
                     setField(4, "blah blah"); });
//etc.

public void submitForm(Integer i) {
  forms.get(i).submitForm(); //probably want to handle NPE here
}

它类似于命令模式。

我不这么认为,但是为什么不这样做:

public void submit() {
  open();
  switch(formNumber) {
    case 1:
    submitForm1();

    case 2:
    submitForm2();

    case 100:
    submitForm100();

    default:
    break;
  }
  submit();
}

暂无
暂无

声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM