我无法找到细分错误？

Question

我已经编写了一个程序来对C ++中的数组执行mergesort。 该程序可以正常编译，但是当我运行它时，它会显示“分段错误（核心已转储）”并退出。 我一直在尝试调试它，但无济于事。 我确定我在某个地方滥用了指针（因此出现了段错误），但是无法将其放置在何处。 有人可以帮我吗？ 谢谢。

#include<iostream>
#include<queue>
#include<algorithm>
#include<math.h>
using namespace std;

void merge(int a[],int start, int middle, int end)
{
  int i;
  queue<int> buffer1;
  queue<int> buffer2;

  for(i = start; i<=middle; i++)
    buffer1.push(a[i]);

  for(i = middle+1; i<=end; i++)
    buffer2.push(a[i]);

  i = start;

  while((!buffer1.empty()) || (!buffer2.empty()))
    {
      if(buffer1.front() < buffer2.front())
    {
      a[i] = buffer1.front();
      buffer1.pop();
      i++;
    }

      else
    {
      a[i] = buffer2.front();
      buffer2.pop();
      i++;
    }
    }

  while(!buffer1.empty())
    {
      a[i] = buffer1.front();
      buffer1.pop();
      i++;
    }

  while(!buffer2.empty())
    {
      a[i] = buffer2.front();
      buffer2.pop();
      i++;
    }


}

void mergeSort(int a[], int start, int end)
{
  int middle;

  if(start<end)
    {
      middle = (start+end)/2;
      mergeSort(a,start,middle);
      mergeSort(a,middle+1,end);
      merge(a, start, middle, end);
    }

}

int main()
{
  int b[6] = {7,8,0,4,5,1},s = 0, e = 5;

  mergeSort(b,s,e);

  for(int i = 0; i<6; i++)
    cout<<b[i]<<endl;

}

这是调试器输出的内容-

execve("./q1", ["./q1"], [/* 63 vars */]) = 0
brk(0)                                  = 0x1cde000
access("/etc/ld.so.nohwcap", F_OK)      = -1 ENOENT (No such file or directory)
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fee90911000
access("/etc/ld.so.preload", R_OK)      = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=116033, ...}) = 0
mmap(NULL, 116033, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7fee908f4000
close(3)                                = 0
access("/etc/ld.so.nohwcap", F_OK)      = -1 ENOENT (No such file or directory)
open("/usr/lib/x86_64-linux-gnu/libstdc++.so.6", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0 \240\10\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0644, st_size=1566568, ...}) = 0
mmap(NULL, 3675328, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7fee9036e000
mprotect(0x7fee904e1000, 2093056, PROT_NONE) = 0
mmap(0x7fee906e0000, 49152, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x172000) = 0x7fee906e0000
mmap(0x7fee906ec000, 13504, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7fee906ec000
close(3)                                = 0
access("/etc/ld.so.nohwcap", F_OK)      = -1 ENOENT (No such file or directory)
open("/lib/x86_64-linux-gnu/libgcc_s.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\360*\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0644, st_size=92504, ...}) = 0
mmap(NULL, 2188352, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7fee90157000
mprotect(0x7fee9016d000, 2093056, PROT_NONE) = 0
mmap(0x7fee9036c000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x15000) = 0x7fee9036c000
close(3)                                = 0
access("/etc/ld.so.nohwcap", F_OK)      = -1 ENOENT (No such file or directory)
open("/lib/x86_64-linux-gnu/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0`\v\2\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=1869392, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fee908f3000
mmap(NULL, 3972864, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7fee8fd8d000
mprotect(0x7fee8ff4d000, 2097152, PROT_NONE) = 0
mmap(0x7fee9014d000, 24576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1c0000) = 0x7fee9014d000
mmap(0x7fee90153000, 16128, PROT_READ|PROT_WRITE, `enter code here`MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7fee90153000
close(3)                                = 0
access("/etc/ld.so.nohwcap", F_OK)      = -1 ENOENT (No such file or directory)
open("/lib/x86_64-linux-gnu/libm.so.6", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\240U\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0644, st_size=1084840, ...}) = 0
mmap(NULL, 3174760, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7fee8fa85000
mprotect(0x7fee8fb8c000, 2093056, PROT_NONE) = 0
mmap(0x7fee8fd8b000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x106000) = 0x7fee8fd8b000
close(3)                                = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fee908f2000
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fee908f0000
arch_prctl(ARCH_SET_FS, 0x7fee908f0740) = 0
mprotect(0x7fee9014d000, 16384, PROT_READ) = 0
mprotect(0x7fee8fd8b000, 4096, PROT_READ) = 0
mprotect(0x7fee9036c000, 4096, PROT_READ) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fee908ef000
mprotect(0x7fee906e0000, 40960, PROT_READ) = 0
mprotect(0x604000, 4096, PROT_READ)     = 0
mprotect(0x7fee90913000, 4096, PROT_READ) = 0
munmap(0x7fee908f4000, 116033)          = 0
brk(0)                                  = 0x1cde000
brk(0x1d10000)                          = 0x1d10000
--- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0} ---
+++ killed by SIGSEGV (core dumped) +++
Segmentation fault (core dumped)

Answer 1

您的while状况似乎不对。 只要两个容器之一不为空，您就在循环，然后在它们上调用front()成员函数。 您可能应该一直循环直到它们都包含元素，即在第21行使用&&代替|| 。

所以这条线

while((!buffer1.empty()) || (!buffer2.empty())) // change to &&

我不确定这是否会破坏代码的逻辑正确性，但这是段错误的原因（它来自第25行）

Answer 2

段错误发生在行上： if (buffer1.front() < buffer2.front())

queue通常只是作为deque或list的包装器实现的，您可以找到更具描述性的警告，以防在queue的方法中调用front ，就像在queue的方法中那样：

在空容器上调用front是未定义的^{[1] [2]}

如果您在Visual Studio中的“调试”下运行，则当遇到段错误时，它将弹出此对话框，您可以单击“重试”以保留所有状态进行调试：

您的问题是在这条线上：

while ((!buffer1.empty()) || (!buffer2.empty()))

这意味着while如果任 -loop执行buffer1 或 buffer2非空。 您需要将该条件更改为：

while (!empty(buffer1) && !empty(buffer2))