Promise.all（）返回所有未定义的结果

Question

我正在从Mongoose的Model.save()建立一个promise数组，但是由于某些原因， Promise.all()返回的数据是一个未定义的数组

码

const saveDataArray = [];
//go through results and save them to the db
Object.keys(passData.scrapeUniqueData).map((index) => {
    const result = gamesExport.addGame(passData.scrapeUniqueData[index], passData.leagueInfo.league_id, passData.leagueInfo.leagueID, passData.leagueInfo.year);
    if(result)
    saveDataArray.push(result);
});

//const -> saveDataArray 
[Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise,  Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise, Promise]

return Promise.all(saveDataArray)
.then((savedDBData) => {
    console.info('savedDBData', savedDBData);
    console.info('saveDataArray', saveDataArray);
    passData.savedDBGames = savedDBData.filter(function(n){ return n != undefined });
    return passData;
})

//const -> savedDBData 
[undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined]

因此，imo savedDBData应该返回与`saveDataArray相同的结果。 为什么Promise.all不返回已保存的数据？

添加游戏

addGame: (details, league_id, leagueID, year) => {
    "use strict";
    if(!details.result && details.result[0] === "P"){
        console.error('result skipped for postponded match');
        return;
    }
    if (details && details.notes !== "Postponed" && !details.postponed) {
        var result = new Games();
        result.fixtureID = details.fixtureID;

        if (details.date.toString().indexOf('z') === -1) {
            result.date = Date.parse(moment(details.date.toString(), "DD-MM-YYYY H:m").format());
        } else {
            result.date = details.date;
        }
        result.home_id = details.home_id._id;
        result.away_id = details.away_id._id;
        result.league_id = league_id;
        result.leagueID = leagueID;
        result.year = year;
        result.norsemen = details.home_id.name.isNorsemen() || details.away_id.name.isNorsemen();

        if (details.result) {
            if (details.result.home === "A" && details.result.away === "A") {
                result.result = ['A', 'A'];
                result.postponed = true;
            } else if (details.result.home === "H" && details.result.away === "W") {
                result.result = ['H', 'W'];
            } else if (details.result.home === "A" && details.result.away === "W") {
                result.result = ['A', 'W'];
            } else if (details.result.home === "C" && details.result.away === "C") {
                result.result = ['C', 'C'];
                result.cancelled = true;
            } else if (details.result.home === "P" && details.result.away === "P") {
                result.result = ['P', 'P'];
                result.postponed = true;
            } else {
                result.result = [parseInt(details.result.home), parseInt(details.result.away, 10)];
            }
        }
        return result.save(function (err, saveData) {
            if (err) console.error(err);
            return result;
        });
    } else {
        return null;
    }
},

Answer 1

当您将回调函数传递给Mongoose方法时，它假定您不会使用它也会返回的诺言。

我不确定这是否是设计使然的（我想是这样，因为否则将同时调用常规回调和promise处理程序，并且结果相同），但是我可以使用如下代码重现您的问题：

let doc = new Model(...);
doc.save((err, res) => {
  console.log('CB RES', res);
}).then(res => {
  console.log('PR RES', res);
});

使用undefined的结果记录PR RES （ “承诺结果” ），但是使用CB RES （ “回调结果” ）记录正确的文档。 如果您没有将回调函数传递给save() ，则PR RES记录正确的文档。

因此，您应该重写addGame以仅返回一个addGame ，而不传递回调函数：

return result.save().catch(function(err) {
  console.error(err);
  // XXX: be aware that if you don't do anything else here,
  //      the error will _just_ be logged, but not propagated.
  //      This is also what your original code does, so I assume
  //      it's intentional.
});