[英]How can I loop through Excel worksheets, in multiple workbooks in the same directory while copying data into a new workbook?
[英]Looping through worksheets in a single workbook while generating new workbooks
我需要在一个工作簿中循环浏览47个不同的工作表。
在每个工作表上运行的宏正在为该工作表创建一个新的单独的工作簿。 我的挑战是,一旦将原始工作簿中的工作表转换为新工作簿,我的宏现在就开始遍历新工作簿(而不是原始工作簿)上的工作表。 我一直在尝试找出某种代码,该代码对原始工作簿上的每个工作表进行计数,然后在创建新工作簿后循环回到原始工作表。
Sub PriceListWest()
'
' PriceListWest Macro
'
Dim Current As Worksheet
Windows("West price list master.xlsm").Activate 'Original workbook'
For Each Current In Worksheets
ActiveSheet.Select 'Selecting worksheet in original workbook'
ActiveSheet.Copy 'Copying worksheet in original workbook'
'Challenge lies here now the loop goes through the new workbook versus returning to original workbook'
Cells.Select
Selection.Copy
Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
:=False, Transpose:=False
Application.CutCopyMode = False
Selection.EntireColumn.Hidden = False
Next
End Sub
除非您不时精确地跟踪哪个工作表/单元处于活动状态,否则使用“ Select
并Activate
是一个坏习惯。 有关避免这些命令的方法的提示,请参阅如何避免使用选择 。
假设您现有的代码成功处理了第一个工作表,则当它开始处理第二个工作表时, ActiveSheet
仍然是第一个工作表的最近创建的副本。 这样该工作表将被复制到另一个工作簿,而不是从原始工作簿中复制一个工作表。
以下代码使用对原始工作簿的引用以及对您的代码已创建的Current
对象的引用,以确保引用了正确的图纸:
Sub PriceListWest()
'
' PriceListWest Macro
'
Dim wbMaster As Workbook
Dim Current As Worksheet
'Set a reference to the original workbook
Set wbMaster = Workbooks("West price list master.xlsm")
'Loop through each sheet in original workbook
For Each Current In wbMaster.Worksheets
'Copy the "current" sheet to a new workbook
Current.Copy
'The "Copy" command has now made the new workbook active, and
' "ActiveSheet" is the newly created sheet in that workbook
With ActiveSheet
'Copy entire sheet
.Cells.Copy
'Paste values
.Cells.PasteSpecial Paste:=xlPasteValues, _
Operation:=xlNone, _
SkipBlanks:=False, _
Transpose:=False
'Unhide all columns
.Columns.Hidden = False
'Set "active" cell to A1, just so the whole sheet isn't selected
.Cells(1, 1).Select
End With
Next
Application.CutCopyMode = False
End Sub
该代码确实继续使用ActiveSheet
但仅在我们知道活动工作表是新创建的工作簿中新复制的工作表的地方使用。
您的主要错误在于,您的Current
变量在遍历Worksheets
集合时会保留当前 worksheet
Worksheets
,而ActiveSheet
是当前的“活动”工作表,并且在您Activate
新工作表之前不会更改(并且循环不会Activate )
在每个ActiveSheet.Copy
,新创建的工作簿将成为ActiveWorkbook
,其唯一的工作表为ActiveSheet
因此您必须使用Current
而不是ActiveSheet
此外,对工作表的所有Cells
进行操作非常耗时,并且可能会引起内存问题:更好地参考Worksheet
对象的UsedRange
属性
所以你可以编写代码:
Option Explicit
Sub PriceListWest()
'
' PriceListWest Macro
'
Dim Current As Worksheet
For Each Current In Workbooks("West price list master").Worksheets
Current.Copy '<--| copy current worksheet from 'original' workbook into a new workbook, this latter becomes the "active" workbook and it's only sheet the "Active" Sheet
With ActiveSheet.UsedRange '<--| reference "Active" worksheet of current "Active" Workbook
.value = .value
.EntireColumn.Hidden = False
End With
Next
End Sub
最后,像上述操作将使您拥有与粘贴表一样多的打开的工作簿,而您可能希望在每次迭代时都保存并关闭它们,从而只剩下“原始”工作簿:
Option Explicit
Sub PriceListWest()
'
' PriceListWest Macro
'
Dim Current As Worksheet
For Each Current In Workbooks("West price list master").Worksheets
Current.Copy '<--| copy current worksheet from 'original' workbook into a new workbook, this latter becomes the "active" workbook and it's only sheet the "Active" Sheet
With ActiveSheet.UsedRange '<--| reference "Active" worksheet of current "Active" Workbook
.value = .value
.EntireColumn.Hidden = False
End With
ActiveWorkbook.SaveAs filepathandname '<-- save current workbook
ActiveWorkbook.Close '<--| close it
Next
End Sub
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.