[英]WHy does this code crash, when used with bin?
如标题所示,我不知道二进制错误在哪里。
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
char binary[360];
void printstringasbinary(char* s)
{
// A small 9 characters buffer we use to perform the conversion
char output[9];
while (*s)
{
// Convert the first character of the string to binary using itoa.
// Characters in c are just 8 bit integers, at least, in noawdays computers.
itoa(*s, output, 2);
strcat(binary, output);
++s;
}
}
int main(int argc, char *argv[])
{
int i, n;
//printf("argc: %i\n", argc);
if (argc != 3)
{
puts("Converter [Text] [hex|dec|bin]");
return 0;
}
FILE *f = fopen("Output.txt", "a");
for (i = 0; i < strlen(argv[0]); i++)
{
if (strcmp(argv[2], "hex") == 0)
fprintf(f, "%X ", (unsigned int) argv[1][i]);
else if (strcmp(argv[2], "dec") == 0)
fprintf(f, "%i ", (unsigned int) argv[1][i]);
else if (strcmp(argv[2], "bin") == 0)
for (n = 0; n < strlen(argv[1]); n++)
{
printstringasbinary(argv[1][i]);
}
fprintf(f, "%s ", binary);
}
fclose(f);
return 0;
}
您可以遍历argv[1][i]
的字符,而i
可以采用不超过argv[0]
字符串长度的值。 根据argv[0]
是否比argv[1]
,这可能导致段错误。 您是说printstringasbinary(argv[1][n])
而不是printstringasbinary(argv[1][i])
吗? 顺便说一句:为什么-正如LP所指出的-您是否完全遍历argv[1]
?
for (i = 0; i < strlen(argv[0]); i++)
....
for (n = 0; n < strlen(argv[1]); n++)
{
printstringasbinary(argv[1][n]);
}
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.