[英]Overloading * operator for complex numbers (C++)
因此,我被要求重载运算符以实现复数的基本算法。 我已经+,-和=工作了,但是即使我认为我有正确的逻辑,我似乎也无法工作。
我的代码有什么问题?
#ifndef COMPLEX_HPP
#define COMPLEX_HPP
#include <string>
class Complex
{
public:
Complex(double = 0.0, double = 0.0); // default constructor
Complex add(const Complex&) const; // function add
Complex subtract(const Complex&) const; // function subtract
Complex multiply(const Complex&) const; // function multiply
std::string toString() const; // return string representation
void setComplexNumber(double, double); // set complex number
void operator=(const Complex& obj)
{
(*this).realPart = obj.realPart;
(*this).imaginaryPart = obj.imaginaryPart;
}
Complex operator+(const Complex& obj)
{
Complex tmp_obj = *this;
tmp_obj.realPart = tmp_obj.realPart + obj.realPart;
tmp_obj.imaginaryPart = tmp_obj.imaginaryPart + obj.imaginaryPart;
return tmp_obj;
}
Complex operator-(const Complex& obj)
{
Complex tmp_obj = *this;
tmp_obj.realPart = tmp_obj.realPart - obj.realPart;
tmp_obj.imaginaryPart = tmp_obj.imaginaryPart - obj.imaginaryPart;
return tmp_obj;
}
Complex operator*(const Complex&obj)
{
Complex tmpObj = *this;
tmpObj.realPart = (tmpObj.realPart * obj.realPart) - (tmpObj.imaginaryPart * obj.imaginaryPart);
tmpObj.imaginaryPart = (tmpObj.realPart * obj.imaginaryPart) + (tmpObj.imaginaryPart * obj.realPart);
return tmpObj;
}
private:
double realPart;
double imaginaryPart;
};
一旦开始覆盖tmpObj
(特别是tmpObj.realPart
),您将丢失原始值。 所以不要从tmpObj
读取,而是从*this
读取:
tmpObj.realPart = realPart * obj.realPart - imaginaryPart * obj.imaginaryPart;
// ^^^^^^^^ ^^^^^^^^^^^^^
tmpObj.imaginaryPart = realPart * obj.imaginaryPart + imaginaryPart * obj.realPart;
// ^^^^^^^^ ^^^^^^^^^^^^^
本质上,您对operator*()
是。
Complex operator*(const Complex&obj)
{
Complex tmpObj = *this;
tmpObj.realPart = (tmpObj.realPart * obj.realPart) - tmpObj.imaginaryPart * obj.imaginaryPart);
tmpObj.imaginaryPart = (tmpObj.realPart * obj.imaginaryPart) + (tmpObj.imaginaryPart * obj.realPart);
return tmpObj;
}
问题在于,第一条语句修改了tmpObj.realPart
,而第二条语句继续进行,就好像tmpObj.realPart
。
解决方法很简单:不要在分配的右侧使用tmpObj
。
Complex operator*(const Complex&obj)
{
Complex tmpObj; // your default constructor initialises to (0.0,0.0)
tmpObj.realPart = (realPart * obj.realPart) - (imaginaryPart * obj.imaginaryPart);
tmpObj.imaginaryPart = (realPart * obj.imaginaryPart) + (imaginaryPart * obj.realPart);
return tmpObj;
}
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.