![](/img/trans.png)
[英]How to make my if statements run again as if-else statement runs?
[英]Both the if statement and the else if statements run
我是java编程的新手,并且一直致力于各种各样的刽子手游戏。 这是我的导师提出的练习,在完成基本版本之后,我想制作一个更先进的练习。 到目前为止,我发现代码中的问题是if语句和else if语句都运行。 为了解决这个问题,我添加了一些break语句。 它确实帮助解决了一个问题但两个语句仍在运行。
这是if else语句错误:
if (guess.equals(letters[i])){
wordi[i] = guess.charAt(i);
System.out.println("Included");
break;
}
else if (!guess.equals(letters[i])){
wordi[i] = '*';
wrong_guess++;
num_guess ++;
System.out.println("Not included");
break;
如果它有帮助,这是完整的代码:
import java.util.Scanner;
public class Test {
public static Scanner input = new Scanner(System.in);
@SuppressWarnings({ "unused" })
public static void main(String[] args) {
String[] words = new String[10];
words[0] = "chair";
words[1] = "apple";
words[2] = "bear";
words[3] = "word";
words[4] = "table";
words[5] = "cow";
words[6] = "cabbage";
words[7] = "food";
words[8] = "computer";
words[9] = "mouse";
int cap_guess = 6;
int wrong_guess = 0;
int n = (int)(Math.random()*10);
String word = words[n];
String out_word = "";
int num_guess = 1;
for(int count = 0; count < word.length(); count ++){
out_word += "*";
}
boolean success = false;
String guess = "";
String[] letters = new String[word.length()];
for (int i = 0; i < letters.length; i++){
letters[i] = word.substring(i,i+1);
System.out.println(letters[i]);
}
while (num_guess <= cap_guess){
display(wrong_guess);
System.out.println(out_word);
System.out.print("Enter a guess: ");
guess = input.nextLine();
guess = guess.trim();
guess = guess.toLowerCase();
System.out.println("Guess: " + guess);
char[] wordi = out_word.toCharArray();
if (guess.length() == 1){
for (int i = 0; i < word.length(); i++){
if (guess.equals(letters[i])){
wordi[i] = guess.charAt(i);
System.out.println("Included");
break;
}
else if (!guess.equals(letters[i])){
wordi[i] = '*';
wrong_guess++;
num_guess ++;
System.out.println("Not included");
break;
}
}
out_word += wordi;
}
}
/*System.out.println(word);
System.out.println(out_word);*/
}
public static void display (int wrong_guess){
if (wrong_guess == 0){
System.out.println("_____________________");
System.out.println(" *----------, |");
System.out.println(" | | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println("______________/-\\____|");
System.out.println("");
}
if (wrong_guess == 1){
System.out.println("_____________________");
System.out.println(" *----------, |");
System.out.println(" | | |");
System.out.println(" /=\\ | |");
System.out.println(" |. .| | |");
System.out.println(" \\-/ | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println("______________/-\\____|");
System.out.println("");
}
if (wrong_guess == 2){
System.out.println("_____________________");
System.out.println(" *----------, |");
System.out.println(" | | |");
System.out.println(" /=\\ | |");
System.out.println(" |. .| | |");
System.out.println(" \\-/ | |");
System.out.println(" | | |");
System.out.println(" | | |");
System.out.println(" | | |");
System.out.println(" | | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println("______________/-\\____|");
System.out.println("");
}
if (wrong_guess == 3){
System.out.println("_____________________");
System.out.println(" *----------, |");
System.out.println(" | | |");
System.out.println(" /=\\ | |");
System.out.println(" |. .| | |");
System.out.println(" \\-/ | |");
System.out.println(" | | |");
System.out.println(" |\\ | |");
System.out.println(" | \\ | |");
System.out.println(" | | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println("______________/-\\____|");
System.out.println("");
}
if (wrong_guess == 4){
System.out.println("_____________________");
System.out.println(" *----------, |");
System.out.println(" | | |");
System.out.println(" /=\\ | |");
System.out.println(" |. .| | |");
System.out.println(" \\-/ | |");
System.out.println(" | | |");
System.out.println(" /|\\ | |");
System.out.println(" / | \\ | |");
System.out.println(" | | |");
System.out.println(" | |");
System.out.println(" | |");
System.out.println("______________/-\\____|");
System.out.println("");
}
if (wrong_guess == 5){
System.out.println("_____________________");
System.out.println(" *----------, |");
System.out.println(" | | |");
System.out.println(" /=\\ | |");
System.out.println(" |. .| | |");
System.out.println(" \\-/ | |");
System.out.println(" | | |");
System.out.println(" /|\\ | |");
System.out.println(" / | \\ | |");
System.out.println(" | | |");
System.out.println(" / | |");
System.out.println(" / | |");
System.out.println("______________/-\\____|");
System.out.println("");
}
if (wrong_guess == 6){
System.out.println("_____________________");
System.out.println(" *----------, |");
System.out.println(" | | |");
System.out.println(" /=\\ | |");
System.out.println(" |x x| | |");
System.out.println(" \\-/ | |");
System.out.println(" | | |");
System.out.println(" /|\\ | |");
System.out.println(" / | \\ | |");
System.out.println(" | | |");
System.out.println(" / \\ | |");
System.out.println(" / \\ | |");
System.out.println("______________/-\\____|");
System.out.println("");
}
}
}
在此先感谢您的帮助。
问题是你的break
。 你没有迭代for循环,你总是打破
for (int i = 0; i < word.length(); i++){
boolean found = false;
if (guess.equals(letters[i])){
wordi[i] = guess.charAt(i);
System.out.println("Included");
found = true;
}
else if (!guess.equals(letters[i])){
wordi[i] = '*';
}
}
if (!found)
wrong_guess++;
num_guess++;
我没有测试但应该没问题
我稍稍清理了你的主要部分,但是我会把一些工作留给你。 您应该将单词列表初始化之类的内容包装到自己的方法中。 实际上,通常建议通常建议将任何可以剥离到自己方法中的代码块。 我不认为你必须走这么极端,但据说你永远不应该有超过8行的方法。 有点武断,但重点是像while循环中发生的事情可以放入自己的方法中。 如果您可以将一段代码描述为执行单个任务,则应将其置于自己的方法中。 这也将在调试时帮助您,因为所有内容都模块化为执行特定任务的代码块。 很容易分辨出问题所在,因为在对所有内容进行适当分解时,代码应仅存在于相关的范围内。 以单词数组初始化为例,这会占用整个垂直空间,与获取用户输入,验证用户输入,显示结果等无关。如果您正在调试某些功能,可能会让人感到困惑。查看与它无关的代码。
@SuppressWarnings({ "unused" })
public static void main(String[] args)
{
String[] words = new String[10];
words[0] = "chair";
words[1] = "apple";
words[2] = "bear";
words[3] = "word";
words[4] = "table";
words[5] = "cow";
words[6] = "cabbage";
words[7] = "food";
words[8] = "computer";
words[9] = "mouse";
int cap_guess = 6;
int wrong_guess = 0;
int num_guess = 1;
String word = words[(int)(Math.random()*10)]; // one lined this
for(Character ch : word.toCharArray()) out_word += '*'; // loop through the char array and fill outword with *
System.out.println("The word is " + word);
boolean success = false;
String[] letters = new String[word.length()];
for (int i = 0; i < letters.length; i++)
{
letters[i] = word.substring(i,i+1);
System.out.println(letters[i]);
}
while (num_guess <= cap_guess && !success)// we want to exit on success as well
{
display(wrong_guess);
System.out.println(out_word);
System.out.print("Enter a guess: ");
char guess = input.nextLine().toCharArray()[0]; // one line this, and it isn't used anywhere else so I moved this to the while loop
System.out.println("Guess: " + guess);
if(word.contains(String.valueOf(guess))) // if the word contains the character
{
System.out.println("Included");
String temp = "";
for(int i = 0; i < out_word.length(); i++)
{
temp += (word.charAt(i) == guess) ? guess : out_word.charAt(i); // "unveils" the correct characters
}
out_word = temp;
System.out.println("Outword: " + out_word);
}
else // else not else if
{
System.out.println("Not Included");
wrong_guess++;
}
num_guess++; // don't need to put this in the if and else
success = word.equals(out_word);
}
if(success) System.out.println("You Won!"); // success
else System.out.println("You Lost!"); // failure
}
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.