[英]Better refactoring of map function
我目前正在重构我的方法。 我已经消除了漫长的foreach和if状态,但是现在我在最后的整理方面苦苦挣扎,以拥有一个不错的map函数。
我的方法看起来像。
/**
* @param \Illuminate\Support\Collection
* @return array
*/
public static function convertTimesToChartData($times) {
$clientTotal = '0';
$arrayIndex = 0;
$chartData = collect($times)->filter(function($item) {
return !is_null($item->end_time);
})->map(function($item) use(&$clientTotal, &$arrayIndex){
$clients[$arrayIndex]['id'] = $item->client_id;
$clients[$arrayIndex]['project_id'] = $item->project_id;
$clients[$arrayIndex]['label'] = $item->company;
$clients[$arrayIndex]['sec'] = $item->end_time->timestamp - $item->start_time->timestamp;
$clientTotal += $item->end_time->timestamp - $item->start_time->timestamp;
$arrayIndex++;
return $clients;
})->flatMap(function($item) { return $item; });
return $chartData;
}
在这里,我有2个问题:
有没有更好的方法分配数组? 当我试图直接在回报中分配时
return [ [$arrayIndex]['id'] => $item->client_id, [$arrayIndex]['project_id'] => $item->project_id, [$arrayIndex]['label'] => $item->company, [$arrayIndex]['sec'] => $item->end_time->timestamp - $item->start_time->timestamp, ];
但是,然后我得到一个未定义的索引错误。
这是原始来源:
$projects = array();
$projectTotal = '0';
foreach($taskTimes as $time){
if(!is_null($time->end_time))
{
if (isset($projects[$time->project_id]))
{
$projects[$time->project_id]['sec'] += $time->end_time->timestamp - $time->start_time->timestamp;
} else
{
$projects[$time->project_id]['id'] = $time->client_id;
$projects[$time->project_id]['label'] = $time->company;
$projects[$time->project_id]['sec'] = $time->end_time->timestamp - $time->start_time->timestamp;
}
$projectTotal += $time->end_time->timestamp - $time->start_time->timestamp;
}
}
感谢您的任何建议和帮助!
为了获得与原始的foreach循环相同的结果,您可以这样做:
$projects = collect($taskTimes)
->filter(function ($time) {
return !is_null($time->end_time);
})
->groupBy('project_id')
->map(function ($group) {
$group = collect($group);
return [
'id' => $group->first()->client_id,
'project_id' => $group->first()->project_id,
'label' => $group->first()->company,
'sec' => $group->sum(function ($item) {
return $item->end_time->timestamp - $item->start_time->timestamp;
}),
];
});
$projectsTotal = $projects->sum('sec');
我已经将project_id
添加到结果数组中,因为它包含在您的convertTimesToChartData()
方法示例中
希望这可以帮助!
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.