[英]Segmentation fault on using shared_ptr with vectors
如果是我犯了一个非常愚蠢的错误并帮助我克服了这种细分错误,我将第一次使用shared_ptr。
我希望有一个私有vector
,即使对象被破坏,也可以从不同的类中读取它。 因此,我读到有关std::shared_ptr
代码在storeCounterData
函数中给出了段storeCounterData
在此先感谢您的帮助 !!!
main.cpp
#include <iostream>
#include "counter.hpp"
#include "getCounter.hpp"
const int max_ports = 3;
int main()
{
Counter *counter = new Counter(3);
counter->age = 1;
counter->id = 12;
counter->pincode = 123;
std::vector<Counter*> counterData;
std::cout<<"inside main"<<std::endl;
counter->storeCounterData(counter,0);
counter->storeCounterData(counter,1);
counter->storeCounterData(counter,2);
std::cout<<"inside main calling getCounterData"<<std::endl;
counter->getCounterData(counterData);
Counter countji(3);
countji.getCounterData(counterData);
//getCounterData class function
getCounter *gcount = new getCounter();
gcount->printCounterData();
return 0;
}
Counter.hpp
#ifndef COUNTERHPP
#define COUNTERHPP
#include <vector>
#include <memory>
class Counter
{
private:
typedef std::shared_ptr<Counter> sharedCtr;
std::vector<sharedCtr> vecData;
public:
Counter();
Counter(int vecSize);
int age, id, pincode;
void storeCounterData(Counter *counter,int user);
void getCounterData(std::vector<Counter*> &counter);
};
#endif
Counter.cpp
#include "counter.hpp"
#include <iostream>
#include <vector>
Counter::Counter()
{
}
Counter::Counter(int vecSize):vecData(vecSize)
{
}
void Counter::storeCounterData(Counter *counter,int user)
{
vecData[user]->age = counter->age;
vecData[user]->id = counter->id;
vecData[user]->pincode = counter->pincode;
std::cout<<"vector size inside storeCounterData = "<<vecData.size()<<std::endl;
}
void Counter::getCounterData(std::vector<Counter*> &counter)
{
std::cout<<"vector size inside getCounterData = "<<vecData.size()<<std::endl;
for (auto& c : vecData)
{
std::cout << c->age << std::endl;
std::cout << c->id << std::endl;
std::cout << c->pincode << std::endl;
}
}
输出量
火箭筒〜/ VECTOR $ ./a.out
内部主要
分段故障(核心已转储)
在Counter
的构造方法中,您将创建一个由empty shared_ptr
的向量,即没有Counter
的托管对象( 请参见此处的(1) )。
只需将行更改为:
Counter(int vecSize) : vecData(vecSize, std::make_shared<Counter>()) {}
编辑:您正在创建一个指针向量,所以我在这里看到两个选项,您希望它起作用:
shared_ptr
实例化向量,但是每当您访问指针时,都需要检查指针是否已经创建。 也许这就是要走的路。 shared_ptr
也是指针,您应该这样对待它们,并始终检查其有效性。
Counter(int vecSize) : vecData(vecSize) {} // previous constructor
void storeCounterData(Counter* counter, int user) {
if (!vecData[user]) {
vecData[user] = std::make_shared<Counter>();
}
vecData[user]->age = counter->age;
vecData[user]->id = counter->id;
vecData[user]->pincode = counter->pincode;
std::cout << "vector size inside storeCounterData = " << vecData.size()
<< std::endl;
}
void getCounterData(std::vector<Counter*>& counter) {
std::cout << "vector size inside getCounterData = " << vecData.size()
<< std::endl;
for (auto& c : vecData) {
if (c) {
std::cout << c->age << std::endl;
std::cout << c->id << std::endl;
std::cout << c->pincode << std::endl;
}
}
}
std::vector::push_back
,以便在std::vector::push_back
只有“有效”(您永远无法确定) shared_ptr
。
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.