[英]Javascript - Generalize a function that can be used in two different ways but in the same context
我已经实现了一个“响应”维度(响应维度)的功能。
这是我目前的方法:
export default (originalDimensions, finalWidth = WINDOW_WIDTH) => {
const responsiveWidth = finalWidth;
const responsiveHeight = ruleOfThree(
originalDimensions.height,
originalDimensions.width,
responsiveWidth
);
return {
width: responsiveWidth,
height: responsiveHeight,
};
};
/* Helper */
function ruleOfThree (originalX, originalY, finalY, direct = true) => {
if (direct) {
return (originalX * finalY) / originalY;
}
return (originalY * finalY) / originalX;
};
如您所见,它只返回一个具有响应尺寸的对象。 我遇到的主要问题是它只使给定的尺寸适应给定的“finalWidth”。 但是,如果我收到的是最终高度而不是 finalWidth(以便该方法将原始宽度调整为该最终高度),该怎么办?
我如何为该方法增加灵活性,以便能够解决该场景而不必创建另一种不同的方法?
任何设计模式或想法?
如果我按如下方式传递最终高度(而不是最终宽度): responsifyDimensions(photo.dimensions, /*finalHeight = 100*/)
然后,该方法必须执行以下操作:
export default (originalDimensions, finalHeight = WINDOW_HEIGHT) => {
const responsiveHeight = finalHeight; <----
const responsiveWidth = ruleOfThree(
originalDimensions.width,
originalDimensions.height, <-----
responsiveHeight <-----
);
return {
width: responsiveWidth,
height: responsiveHeight,
};
}
代码看起来非常相似......所以我想可能有一种简单的方法可以使原始方法更加“灵活”
我会在最后一个参数中进行对象解构,然后,根据设置的值,我会切换宽度/高度,如下所示:
export default (originalDimensions, { finalWidth, finalHeight } = {}) => {
if (finalHeight) {
return {
width: ruleOfThree(
originalDimensions.height,
originalDimensions.width,
finalHeight
),
height: finalHeight,
};
}
const width = finalWidth ?? WINDOW_WIDTH;
return {
width,
height: ruleOfThree(
originalDimensions.width,
originalDimensions.height,
width
),
};
};
/* Helper */
function ruleOfThree (originalX, originalY, finalY, direct = true) => {
if (direct) {
return (originalX * finalY) / originalY;
}
return (originalY * finalY) / originalX;
};
/* usage */
// Fit width
const dimsWidth = responsifyDimensions(photo.dimensions, { finalWidth: 100 });
// Fit height
const dimsHeight = responsifyDimensions(photo.dimensions, { finalHeight: 100 });
// Fit default (WINDOW_WIDTH as width)
const dimsDefault = responsifyDimensions(photo.dimensions);
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.